Clean the use of weights in graph.py

[dcoudert]

part of #13112 and follow-up of #32723.

Here we clean methods:

• eccentricity
• radius
• diameter

Component: graph theory

Author: David Coudert

Branch/Commit: 725e2ee

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/32802

[dcoudert]

Branch: public/graphs/32802_graph

[dcoudert]

Commit: b94f1eb

[dcoudert]

New commits:

b94f1eb

trac #32802: weights in eccentricity, radius, diameter

[dcoudert]

comment:2

The error reported by the patchbot in src/sage/schemes/toric/sheaf/klyachko.py has already been reported in #32773.

[videlec]

comment:4

Could you replace w_func by weight_function in

         if algorithm == 'DHV':
+            by_weight, w_func = self._get_weight_function(by_weight=by_weight,
+                                                          weight_function=weight_function,
+                                                          check_weight=check_weight)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

761c4ec	trac #32802: merged with 9.5.beta9
725e2ee	trac #32802: review commit

[sagetrac-git]

Changed commit from b94f1eb to 725e2ee

[dcoudert]

comment:6

It's nicer this way

[videlec]

comment:7

Thanks.

BTW, why is it called _get_weight_function and not simply _weight_function?

[videlec]

Reviewer: Vincent Delecroix

[dcoudert]

comment:9

BTW, why is it called _get_weight_function and not simply _weight_function?

I had to find a name... it can be changed for something shorter, but only after we are done with the cleaning of the usage of weights in the graph module (#13112).

Thanks for the review.

[vbraun]

Changed branch from public/graphs/32802_graph to 725e2ee