Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the use of weights in generic_graph.py - part 2 #32800

Closed
dcoudert opened this issue Oct 30, 2021 · 12 comments
Closed

Clean the use of weights in generic_graph.py - part 2 #32800

dcoudert opened this issue Oct 30, 2021 · 12 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@dcoudert
Copy link
Contributor

part of #13112 and follow-up of #32723.

Here we clean methods:

  • distance
  • centrality_closeness
  • shortest_path
  • shortest_path_length

CC: @fchapoton

Component: graph theory

Author: David Coudert

Branch/Commit: 5b01e71

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32800
@dcoudert dcoudert added this to the sage-9.5 milestone Oct 30, 2021
@dcoudert
Copy link
Contributor Author

Branch: public/graphs/32800_part2

@dcoudert
Copy link
Contributor Author

New commits:

6281b32trac #32800: weights in distance, closeness_centrality, shortest_path

@dcoudert
Copy link
Contributor Author

Commit: 6281b32

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

17218d8trac #32800: shortest_path_length

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2021

Changed commit from 6281b32 to 17218d8

@dcoudert

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2021

Changed commit from 17218d8 to 5b01e71

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5b01e71trac #32800: fix some cases

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:5

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@fchapoton
Copy link
Contributor

comment:7

ok, ca m'a l'air correct

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from public/graphs/32800_part2 to 5b01e71

@vbraun vbraun closed this as completed in d46009e Feb 13, 2022
@dkrenn dkrenn mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @mkoeppe @dcoudert