Skip to content

Meta-ticket: Fix E701, E702, W605 for tox -e pycodestyle-minimal #31966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kliem opened this issue Jun 12, 2021 · 25 comments
Closed

Meta-ticket: Fix E701, E702, W605 for tox -e pycodestyle-minimal #31966

kliem opened this issue Jun 12, 2021 · 25 comments

Comments

@kliem
Copy link
Contributor

kliem commented Jun 12, 2021

We fix code style to address code style reports by
pycodestyle, for warnings and error codes:

E701 multiple statements on one line (colon)
E702 multiple statements on one line (semicolon)
W605 invalid escape sequence '\Z'

See:

This makes tox -e pycodestyle-minimal pass
with the current configuration.

As this touches many files, we split this into
several smaller tickets.

Related:

CC: @slel

Component: refactoring

Keywords: pycodestyle

Issue created by migration from https://trac.sagemath.org/ticket/31966

@kliem kliem added this to the sage-9.4 milestone Jun 12, 2021
@fchapoton
Copy link
Contributor

comment:1

see #31286, waiting since 5 months

@fchapoton
Copy link
Contributor

comment:2

see also #31794

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

comment:3

Thanks for the quick pointer. I didn't really get anything done yet.

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

comment:5

I just think it would be nice to have the lint badge green per default.

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

Branch: u/gh-kliem/fix_pycodestyle_minimal

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

comment:6

The branch is for reference only.


Last 10 new commits:

953cda1E701, E702 for rings
946105eE701, E702 for docs, plot, misc
75d2dadE701, E702 for geometry
443f41eE701, E702 for algebras, crypto, quadratic form, structure
6f8b610E701, E702 for modular
b2e92c8E701, E702 for interfaces
c71914bE701, E702 for groups
ae3f45eE701, E702 for databases
0875fc6E701, E702 for categories, schemes, tensor, functions
a4b0c88E701, E702 for matrix, all.py

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

Commit: a4b0c88

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor Author

kliem commented Jun 12, 2021

comment:8

With those tickets above, tox -e pycodestyle-minimal succeeds for me.

@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jun 13, 2021

comment:9

See discussion at #31968, one of the tickets from this meta-ticket.

@slel slel changed the title Fix E701, E702, W605 for tox -e pycodestyle-minimal Meta-ticket Fix E701, E702, W605 for tox -e pycodestyle-minimal Jun 13, 2021
@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Jun 13, 2021

comment:10

Maybe component "refactoring" is more adapted than "doctest framework".

@slel slel changed the title Meta-ticket Fix E701, E702, W605 for tox -e pycodestyle-minimal Meta-ticket: Fix E701, E702, W605 for tox -e pycodestyle-minimal Jun 13, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f91363bfix stupid mistakes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2021

Changed commit from a4b0c88 to f91363b

@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor

Changed branch from u/gh-kliem/fix_pycodestyle_minimal to none

@fchapoton
Copy link
Contributor

Changed commit from f91363b to none

@fchapoton
Copy link
Contributor

comment:13

I removed the branch, as this is a metaticket

@fchapoton
Copy link
Contributor

comment:14

This will probably need one last pass, once all tickets are closed.

@kliem
Copy link
Contributor Author

kliem commented Jul 3, 2021

comment:15

The branch was just illustrating that things worked, once everything is merged. Sorry it is confusing.

@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jul 19, 2021
@mkoeppe mkoeppe added this to the sage-9.5 milestone Jul 19, 2021
@fchapoton

This comment has been minimized.

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor Author

kliem commented Oct 5, 2021

comment:18

With #32571 this ticket can be closed:

https://github.com/sagemath/sagetrac-mirror/actions/runs/1279015500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants