State global i or I is a number field element (and no longer in the symbolic ring)

[slel]

After #18036, the global i or I is defined as
a number field element rather than a symbolic constant.

Necessary adaptations throughout the code base were
made in #18036, as well as a deprecation in src/sage/symbolic/all.py, which should be updated
only after the usual one year deprecation period (starting
from the release of Sage 9.3).

Only a few more documentation bits need updating in:

• src/doc/*/tutorial/tour_rings.pyx
• src/sage/rings/complex_mpfr.pyx

as revealed by

git grep '``I``' src | grep ymbol
git grep '``I``' src/doc

Many places could also get the symbolic I directly
using SR.I() rather than converting with SR(I).

CC: @mezzarobba @slel @videlec @tscrim @umedoblock @embray

Component: documentation

Author: Marc Mezzarobba, Samuel Lelièvre, Travis Scrimshaw

Branch/Commit: da6bd33

Reviewer: Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, Hideyuki Yasuda

Issue created by migration from https://trac.sagemath.org/ticket/31758

[mezzarobba]

Branch: u/mmezzarobba/31758

[mezzarobba]

Commit: b2f4df2

[mezzarobba]

Author: Marc Mezzarobba

[mezzarobba]

New commits:

b2f4df2

#31758 minor doc update after #18036

[mkoeppe]

Reviewer: Matthias Koeppe

[slel]

comment:3

In sage.rings.complex_mpfr.is_ComplexNumber, let us
keep an introductory sentence for the example showing
that 1 + 2*I and CC(1 + 2*I) behave differently.

Let us also change the files src/doc/*/tutorial/tour_rings.tst
that used to mention the global I as symbolic.

The Japanese one at src/doc/*/tutorial/tour_rings.tst
still needs editing; the others need proofreading.

[slel]

Changed author from Marc Mezzarobba to Marc Mezzarobba, Samuel Lelièvre

[slel]

Changed commit from b2f4df2 to 3d67f89

[slel]

New commits:

3d67f89

31758: State the global I is an algebraic number

[slel]

Changed branch from u/mmezzarobba/31758 to public/31758

[slel]

comment:7

Back to positive review, let's keep the missing bits
for a follow-up ticket.

Sorry for delaying this.

[slel]

comment:8

Oops, I just gave positive review to my own changes.

Can someone fluent in Japanese check how to make similar changes in

• https://github.com/sagemath/sage-prod/blob/develop/src/doc/ja/tutorial/tour_rings.rst

as were done in

• sagemath/sagetrac-mirror@3d67f89

Ideally in this ticket. Otherwise in a follow-up ticket.

[sagetrac-git]

Changed commit from 3d67f89 to da6bd33

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e9f8210	Merge branch 'public/31758' of git://trac.sagemath.org/sage into public/31758
da6bd33	Updating Japanese and tweak to English tour_rings.rst.

[tscrim]

Changed reviewer from Matthias Koeppe to Matthias Koeppe, Travis Scrimshaw

[tscrim]

comment:10

I have updated the Japanese version. I also removed a comma from the English version as I believe it makes the sentence grammatically incorrect.

[tscrim]

comment:11

My partner (who is Japanese) also double-checked my changes.

[slel]

Changed author from Marc Mezzarobba, Samuel Lelièvre to Marc Mezzarobba, Samuel Lelièvre, Travis Scrimshaw

[slel]

comment:12

Fantastic. Anyone happy to set this to positive review?

[tscrim]

comment:13

Since I made the last commit, I should not do it. However, please go ahead since you seem to approve of my changes. :)

[umedoblock]

comment:14

I'm a Japanese.

I agree with tscrim.

[slel]

Changed reviewer from Matthias Koeppe, Travis Scrimshaw to Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre

[slel]

comment:15

Travis, I gather you give positive review to my changes.

gh-umedoblock, add your full name to the reviewers field
if you want to.

This seems ready to go in.

[umedoblock]

comment:16

slelievre, I added my name to the reviewers.

[umedoblock]

Changed reviewer from Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre to Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, gh-umedoblock

[tscrim]

comment:17

It should be your real name.

[umedoblock]

comment:18

OK ?

[umedoblock]

Changed reviewer from Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, gh-umedoblock to Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, Hideyuki YASUDA

[tscrim]

comment:19

はい。記入頂きどうもありがとうございます。

[tscrim]

Changed reviewer from Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, Hideyuki YASUDA to Matthias Koeppe, Travis Scrimshaw, Samuel Lelièvre, Hideyuki Yasuda

[vbraun]

Changed branch from public/31758 to da6bd33