Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from --without-system-SPKG to --with-system-SPKG does not trigger rebuilds of dependent packages #31277

Open
mkoeppe opened this issue Jan 22, 2021 · 2 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 22, 2021

As observed, for example, in #31267:
Build SPKG readline, build SPKG singular (which has the dependency on readline); then removing the SPKG readline and using the system readline does not trigger a rebuild of singular.

This is caused by a shortcoming of our build system: All system packages are represented by the target $SAGE_LOCAL/var/lib/sage/installed/.dummy - which is old.

As a solution, we replace use of .dummy by separate files that represent system packages in
$SAGE_LOCAL/var/lib/sage/system/....

These files can just be empty regular files, but in some cases, they could be symlinks to system files, so that an update of a system package triggers the rebuild of a Sage package.

sage.misc.package would be extended to also read these installation records.

CC: @dimpase @jhpalmieri @orlitzky

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/31277

@mkoeppe mkoeppe added this to the sage-9.3 milestone Jan 22, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:1

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Switching from --with-system-SPKG to --without-system-SPKG does not trigger rebuilds of dependent packages Switching from --without-system-SPKG to --with-system-SPKG does not trigger rebuilds of dependent packages Jan 15, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant