Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: Make build more robust by clearing some environment variables #31094

Closed
mkoeppe opened this issue Dec 22, 2020 · 11 comments
Closed

openssl: Make build more robust by clearing some environment variables #31094

mkoeppe opened this issue Dec 22, 2020 · 11 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 22, 2020

... in particular SYSTEM, set by our tox.ini, breaks the openssl build as seen in https://github.com/mkoeppe/sage/runs/1592276838:

  [openssl-1.1.1i]   Configuring openssl...
  [openssl-1.1.1i]   Operating system: x86_64-whatever-$(build/bin/sage-guess-package-system)
  [openssl-1.1.1i]   This system ($(build/bin/sage) is not supported. See file INSTALL for details.
  [openssl-1.1.1i]   Error configuring openssl.

CC: @sagetrac-tmonteil @kliem @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 5c169c7

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31094

@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 22, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2020

Commit: 5c169c7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2020

New commits:

5c169c7build/pkgs/openssl/spkg-install.in: Unset some environment variables

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2020

Author: Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Dec 22, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 23, 2020

comment:5

Build with this ticket merged went through in https://github.com/mkoeppe/sage/actions/runs/437548563 for #31082. Needs review

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2021

comment:6

Still needs review, let's please get this in

@kliem
Copy link
Contributor

kliem commented Jan 2, 2021

comment:7

LGTM.

@kliem
Copy link
Contributor

kliem commented Jan 2, 2021

Changed reviewer from https://github.com/kliem/sage/pull/31/checks to Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 3, 2021

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 4, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants