Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...) #31062

Closed
mkoeppe opened this issue Dec 16, 2020 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 16, 2020

(from #30556)

... because we still don't have openssl on some platforms and so can't install pip packages.

We also make two minor fixes to package dependencies that are conditionalized on SAGE_CHECK:

_____________ ERROR collecting src/rpy2/tests/ipython/test_html.py _____________
ImportError while importing test module '/sage/local/var/tmp/sage/build/rpy2-3.3.6/src/rpy2/tests/ipython/test_html.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
src/rpy2/tests/ipython/test_html.py:4: in <module>
    from rpy2.ipython import html
src/rpy2/ipython/__init__.py:1: in <module>
    from . import rmagic
src/rpy2/ipython/rmagic.py:89: in <module>
    from IPython.core import displaypub
E   ModuleNotFoundError: No module named 'IPython'

Depends on #30944

CC: @jhpalmieri @kliem @seblabbe @dimpase @tobiasdiez

Component: porting

Author: Matthias Koeppe

Branch/Commit: b25ea3b

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31062

@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 16, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...) if there is no ssl tox / GH Actions: Disable testsuites of packages depending on pip packages (pytest, ...) Dec 16, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

New commits:

9ad611dtox.ini, build/bin/write-dockerfile.sh: Add !sage_sws2rst, !rpy2 to SAGE_CHECK_PACKAGES
48657d2build/pkgs/sage_sws2rst/dependencies: Fix typo - use SAGE_CHECK_sage_sws2rst

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

Commit: 48657d2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 16, 2020

Dependencies: #30944

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 16, 2020

Changed commit from 48657d2 to 380c718

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 16, 2020

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

559dd8etox.ini (local-root): Pass --enable-build-as-root to configure
a85f41ctox.ini (local): Do not build the toolchain when posargs = config.status or posargs = configure
1de912atox.ini (local-sudo): Run apt-get update with sudo
3c7e5c4tox.ini (local-root, local-sudo): Run output of sage-print-system-package-command through eval
571cc49Merge branch 't/30947/src_doc_bootstrap__simplify_by_using_new_options_of__sage__package_list_' into t/29124/script-packages-prereq-toolchain-bootstrap
f7ff30cMerge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/30944/tox__improve_local_sudo_ubuntu_standard
c529729Merge commit '3bb309944b7e8542b2ac88ed3c9d9a60e68644d7' of git://trac.sagemath.org/sage into t/29124/script-packages-prereq-toolchain-bootstrap
b73d6f0Merge tag '9.3.beta4' into t/29124/script-packages-prereq-toolchain-bootstrap
e9ca2c1Merge branch 't/29124/script-packages-prereq-toolchain-bootstrap' into t/30944/tox__improve_local_sudo_ubuntu_standard
380c718Merge branch 't/30944/tox__improve_local_sudo_ubuntu_standard' into t/31062/tox___gh_actions__disable_testsuites_of_packages_depending_on_pip_packages__pytest_______if_there_is_no_ssl

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2020

Changed commit from 380c718 to b25ea3b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

b25ea3bbuild/pkgs/rpy2/dependencies: If SAGE_CHECK=yes, depend on ipython

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 20, 2020

comment:8

Let's please get this ticket in so that our CI runs work again normally

@kliem
Copy link
Contributor

kliem commented Dec 22, 2020

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/426748847 to Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Dec 22, 2020

comment:10

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 23, 2020

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants