Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/make/Makefile.in: Fix SAGE_CHECK logic, conditionalize sagetex dependencies on SAGE_CHECK #31020

Closed
mkoeppe opened this issue Dec 7, 2020 · 8 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 7, 2020

(from #30315)

As previously observed in #30324, the SAGE_CHECK logic implemented in #30118 and improved in #29766 still does not work correctly with dependencies conditionalized on SAGE_CHECK.

We fix it (again...?!) by moving the computation of the SAGE_CHECK_... variables earlier, before the dependencies are evaluated.

To test it, we conditionalize sagetex dependencies on SAGE_CHECK:

$ make sagetex-clean jmol-clean
$ make sagetex                    # should NOT build jmol
$ make sagetex-clean
$ SAGE_CHECK=yes make sagetex     # now it builds jmol

CC: @jhpalmieri @dimpase @kliem @orlitzky

Component: build

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: 1f714c1

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31020

@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 7, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2020

Commit: 1f714c1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2020

New commits:

0ed256cbuild/make/Makefile.in: Compute SAGE_CHECK_... earlier, before evaluating dependencies
1f714c1build/pkgs/sagetex/dependencies: Conditionalize order-only deps on SAGE_CHECK_sagetex

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Changed keywords from none to sd111

@dimpase
Copy link
Member

dimpase commented Dec 10, 2020

comment:4

lgtm

@dimpase
Copy link
Member

dimpase commented Dec 10, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants