-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/make/Makefile.in: Fix SAGE_CHECK logic, conditionalize sagetex dependencies on SAGE_CHECK #31020
Labels
Milestone
Comments
Commit: |
Changed keywords from none to sd111 |
comment:4
lgtm |
Reviewer: Dima Pasechnik |
comment:5
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(from #30315)
As previously observed in #30324, the
SAGE_CHECK
logic implemented in #30118 and improved in #29766 still does not work correctly with dependencies conditionalized onSAGE_CHECK
.We fix it (again...?!) by moving the computation of the
SAGE_CHECK_...
variables earlier, before the dependencies are evaluated.To test it, we conditionalize
sagetex
dependencies onSAGE_CHECK
:CC: @jhpalmieri @dimpase @kliem @orlitzky
Component: build
Keywords: sd111
Author: Matthias Koeppe
Branch/Commit:
1f714c1
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/31020
The text was updated successfully, but these errors were encountered: