Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage_setup: Separate installing and cleaning #30780

Closed
mkoeppe opened this issue Oct 16, 2020 · 13 comments
Closed

sage_setup: Separate installing and cleaning #30780

mkoeppe opened this issue Oct 16, 2020 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 16, 2020

This is preparation for #28925.

Depends on #30779

CC: @tobiasdiez @dimpase @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch: ad9402f

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30780

@mkoeppe mkoeppe added this to the sage-9.3 milestone Oct 16, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

New commits:

4f56517Duplicate src/setup.py
7980130Merge branch 't/30779/duplicate_src_setup_py' into t/30780/sage_setup__separate_installing_and_cleaning
9b95628sage_setup.command.sage_install.sage_install: Rename to sage_install_and_clean, update use it in build/pkgs/sagelib/src/setup.py; refactor through new class sage_install

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

Commit: 9b95628

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2020

Changed commit from 9b95628 to ad9402f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

ad9402fsage_setup.command.sage_install: Fixup: Remove cleaning code (moved to sage_install_and_clean)

@dimpase
Copy link
Member

dimpase commented Nov 11, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Nov 11, 2020

comment:7

ok

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 11, 2020

comment:8

Thanks

@vbraun
Copy link
Member

vbraun commented Nov 22, 2020

@embray
Copy link
Contributor

embray commented Dec 1, 2020

comment:10

Why did this include a whole entire duplicate of setup.py?

@embray
Copy link
Contributor

embray commented Dec 1, 2020

Changed commit from ad9402f to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 1, 2020

comment:11

The duplication was done in #30779, a dependency of this ticket. This is preparing for Tobias Diez's work for editable installs (setup.py develop) in #30371 out of src/ and the work in #29705 regarding modularization, which is taking place in build/pkgs/sagelib/src. At some point they will be reconciled again, but for the time being it simplifies development to keep the two copies separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants