-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ecm on macOS Xcode 12 #30600
Comments
Commit: |
New commits:
|
comment:2
I think that most of the changes to
(I assume that you got this by running |
comment:4
sure, it's just the result of an autoreconf run. I don't think we should be bothered by this, it's clearly a temporary patch, to go away with a new |
Reviewer: John Palmieri |
comment:6
Build depends on autotools:
|
comment:7
[speaking as upstream developer] I believe this has to be fixed on the Sage side, since the vanilla 7.0.4 tarball should not depend on autotools. |
comment:8
I think we can just patch |
Changed branch from u/dimpase/packages/ecm/xcode12patch to u/jhpalmieri/packages/ecm/xcode12patch |
New commits:
|
comment:11
ok, good catch! |
comment:12
it would be cleaner to run |
comment:13
Replying to @zimmermann6:
I think that's how Dima produced the patch in the first place. I just removed the part of the patch affecting |
comment:14
Replying to @zimmermann6:
this what I did - but I only took updates of acinclude.m4 and ./configure, not the complete stuff. My fault. |
Changed branch from u/jhpalmieri/packages/ecm/xcode12patch to |
Changed commit from |
comment:16
Paul, is there any chance that a new release will be made soon with these updates? |
comment:17
I've put a candidate tarball at https://members.loria.fr/PZimmermann/ecm-7.0.5-dev.tar.gz, please can you confirm it is ok? If so, I will make a new release. |
comment:18
Replying to @zimmermann6:
still waiting for an answer... |
comment:19
Sorry, let's take this to #31325 |
as discussed on #30494
and fixed upstream on
https://gforge.inria.fr/tracker/index.php?func=detail&aid=21856&group_id=135&atid=623
Upstream: Fixed upstream, but not in a stable release.
CC: @mkoeppe @jhpalmieri @zimmermann6
Component: packages: standard
Author: Dima Pasechnik
Branch:
1991357
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/30600
The text was updated successfully, but these errors were encountered: