Use reference instead of pointer to simplify code

[kliem]

By using a reference to a structure the code is much better to read.

Instead of structptr[0].newfaces[structptr[0].current_dimension-1] we now have structure.newfaces[structure.current_dimension-1].

Depends on #30524

CC: @tscrim

Component: geometry

Keywords: combinatorial polyhedron, face iterator

Author: Jonathan Kliem

Branch/Commit: 5b21614

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30529

[kliem]

Changed keywords from none to combinatorial polyhedron, face iterator

[tscrim]

comment:3

If you could just rebase the branch to clean up the history a bit, then you can set a positive review.

[tscrim]

Reviewer: Travis Scrimshaw

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

f3e2ddc	prepare slightly modified algorithm for simple/simplicial polytopes
edad681	typo
5939b5d	faster algorithm for simple/simplicial polytopes
f997cec	small fixes
63b7bd6	improvements in documentation
f2edc3d	get rid of maybe_newfaces
6dfbe81	get rid of compute_dimension_loop
f2dd072	do not expose the coatoms
fc8124a	fix mistake
4f86f02	use reference so simplify code

[sagetrac-git]

Changed commit from df7d31c to 4f86f02

[sagetrac-git]

Changed commit from 4f86f02 to 5b21614

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5b21614

use reference so simplify code

[kliem]

comment:6

Replying to @tscrim:

If you could just rebase the branch to clean up the history a bit, then you can set a positive review.

Thank you. This ticket is only one commit. Now you can see it.

[vbraun]

Changed branch from u/gh-kliem/simplify_face_struct_pointer to 5b21614