Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete changelog sections from all SPKG.txt files #29636

Closed
mkoeppe opened this issue May 3, 2020 · 12 comments
Closed

Delete changelog sections from all SPKG.txt files #29636

mkoeppe opened this issue May 3, 2020 · 12 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 3, 2020

They only cover ancient history.

CC: @jhpalmieri @dimpase @fchapoton @slel @williamstein

Component: build

Author: Matthias Koeppe

Branch/Commit: 079224e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29636

@mkoeppe mkoeppe added this to the sage-9.1 milestone May 3, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

Commit: 079224e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

New commits:

aa9ada9Delete changelog sections from all SPKG.txt files
079224eRemove remaining SPKG.txt changelog sections manually

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

comment:3

It's critical to remove these sections because they make look Sage's packages much more outdated than they are.

@dimpase
Copy link
Member

dimpase commented May 3, 2020

comment:4

I agree that something needs to be done, but not this way - these changelogs may hold sentimental value for people involved (especially as Sage used to be developed using patches rather than commits to a VCS).

How about moving these sections into separate files named
old_changelog.txt or something like this? (each of them may start with a notice like

Historical - check git logs for recent changes

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

comment:5

We do have historical changelogs on the website, listing individual contributions of authors. http://www.sagemath.org/changelogs/index.html
I would think that it is sufficient.

Keeping this in the source tree can't be the right solution.

In particular, if we keep the old spkg changelogs in the tree, then the contributions of newer contributors are not represented.

@dimpase
Copy link
Member

dimpase commented May 3, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented May 3, 2020

comment:8

OK, then perhaps something like mentioning a git incantation to use to see the data removed here, in https://wiki.sagemath.org/ReleaseTours/sage-9.1
(or perhaps just copy it there, under a separate heading)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

comment:9

See #29640 - Create an AUTHORS.md file with links

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2020

comment:10

I have also added a "Spring cleaning" section to https://wiki.sagemath.org/ReleaseTours/sage-9.1 which mentions this removal

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 17, 2020
@vbraun
Copy link
Member

vbraun commented May 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants