-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplicity and simpliciality to polyhedra #29186
Comments
Commit: |
Branch: public/29186 |
New commits:
|
Reviewer: Jean-Philippe Labbé |
comment:2
Some comments: - Return the largest `k` such that the polytope is `k`-simple.
-
- Return the dimension in case of a simplex.
-
- A polytope `P` is `k`-simple, if every `(d-1-k)`-face
- is contained in exactly `k+1` facets of `P` for `1 <= k <= d-1`.
-
- Equivalently it is `k`-simple if the polar/dual polytope is `k`-simplicial.
+ Return the largest integer `k` such that the polytope is `k`-simple.
+
+ A polytope `P` is `k`-simple, if every `(d-1-k)`-face
+ is contained in exactly `k+1` facets of `P` for `1 <= k <= d-1`.
+ Equivalently it is `k`-simple if the polar/dual polytope is `k`-simplicial.
+ If `self` is a simplex, it returns its dimension. similarly: - Return the largest `k` such that the polytope is `k`-simplicial.
-
- Return the dimension in case of a simplex.
-
- A polytope is `k`-simplicial, if every `k`-face is a simplex.
+ Return the largest interger `k` such that the polytope is `k`-simplicial.
+
+ A polytope is `k`-simplicial, if every `k`-face is a simplex.
+ If `self` is a simplex, returns its dimension. Once this is fixed and the bots gives a green light, you can set this on positive review on my behalf. |
Changed branch from public/29186 to public/29186-reb |
comment:4
Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date. |
comment:5
Small things: + is contained in exactly `k+1` facets of `P` for `1 <= k <= d-1`. You can use Otherwise, looks good, once this is done you can put this on positive review on my behalf. |
Changed branch from public/29186-reb to public/29186-reb2 |
Changed branch from public/29186-reb2 to |
In #27086 we have implemented simplicity and simpliciality for combinatorial polyhedra. We expose this methods in
Polyhedron_base
.The methods return the largest
k
such that the polytope isk
-simple/simplicial. In case of unbounded polyhedra aNotImplementedError
is raised.A polytope is
k
-simplicial if everyk
-face is a simplex. It isk
-simple if its dual/polar isk
-simplicial.CC: @jplab @LaisRast
Component: geometry
Keywords: simplicity, simpliciality, polytopes
Author: Jonathan Kliem
Branch/Commit:
573dbfc
Reviewer: Jean-Philippe Labbé
Issue created by migration from https://trac.sagemath.org/ticket/29186
The text was updated successfully, but these errors were encountered: