-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gale_transform
does not work for RDF
#29073
Labels
Milestone
Comments
Branch: public/29073 |
Commit: |
Author: Jonathan Kliem |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
In For inexact rings use :meth:`right_kernel_matrix` with
- ``basis='computed'`` to avoid echolonizing.
+ ``basis='computed'`` (on the transpose of the matrix) to avoid echolonizing. Otherwise, it is good to go. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Laith Rastanawi |
Changed branch from public/29073 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the Gale transform for
RDF
does not workbut the sum should be close to zero. This is of course only an indication that something goes terribly wrong. For #29065, I wanted to add a doctest recovering an inexact polyhedron from the gale diagram, but it simply does not work.
The problem is quite simple. The method
right_kernel
for matrices, should just not be used, as it echolonizes the kernel. This is just something, one shouldn't do for inexact rings. The methodright_kernel_matrix(basis=computed)
gives a much more useful matrix.We also leave a note in
left_kernel
,right_kernel
, andright_kernel_matrix
to indicate this problem.CC: @jplab @LaisRast
Component: geometry
Keywords: polytopes, gale transform, RDF
Author: Jonathan Kliem
Branch/Commit:
9683151
Reviewer: Laith Rastanawi
Issue created by migration from https://trac.sagemath.org/ticket/29073
The text was updated successfully, but these errors were encountered: