Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 perfect_matching #28210

Closed
jhpalmieri opened this issue Jul 17, 2019 · 6 comments
Closed

py3 perfect_matching #28210

jhpalmieri opened this issue Jul 17, 2019 · 6 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-8.9

Comments

@jhpalmieri
Copy link
Member

Fix the py3 doctest failures in combinat/perfect_matching.py.

Component: python3

Author: John Palmieri

Branch/Commit: 363729d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28210
@jhpalmieri jhpalmieri added this to the sage-8.9 milestone Jul 17, 2019
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/perfect_matching

@jhpalmieri
Copy link
Member Author

comment:2

I marked some doctests random, and then I added extra tests to make sure the output was still mathematically correct. This may be a bit of overkill, but at least the newly added stuff has all gone into TESTS blocks, so it should be hidden from casual users.

New commits:

363729dtrac 28210: fix the three py3 doctest failures in combinat/perfect_matching.py

@jhpalmieri
Copy link
Member Author

Commit: 363729d

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok, thx

@vbraun
Copy link
Member

vbraun commented Jul 23, 2019

Changed branch from u/jhpalmieri/perfect_matching to 363729d

@vbraun vbraun closed this as completed in ed5f509 Jul 23, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @fchapoton