Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix last doctest in ext folder #27975

Closed
fchapoton opened this issue Jun 12, 2019 · 8 comments
Closed

py3: fix last doctest in ext folder #27975

fchapoton opened this issue Jun 12, 2019 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.9

Comments

@fchapoton
Copy link
Contributor

by adding the tag not tested.

This appears in a piece of doc testing a piece of code which is not supposed to work!!!

CC: @tscrim @jhpalmieri @vinklein

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 8090659

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/27975
@fchapoton fchapoton added this to the sage-8.8 milestone Jun 12, 2019
@fchapoton
Copy link
Contributor Author

New commits:

8090659py3: fix last doctest in ext folder

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27975

@fchapoton
Copy link
Contributor Author

Commit: 8090659

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jun 12, 2019

comment:2

Looks good to me.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jun 12, 2019

Reviewer: Vincent Klein

@slel

This comment has been minimized.

Sign in to view
@slel slel changed the title p3: fix last doctest in ext folder py3: fix last doctest in ext folder Jun 12, 2019
@vbraun
Copy link
Member

vbraun commented Jun 28, 2019

Changed branch from u/chapoton/27975 to 8090659

@vbraun vbraun closed this as completed in 8a9ed18 Jun 28, 2019
@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:6

Not in Sage 8.8. Let's please to try keep tickets' milestones related to the release in which we actually intend to include them, and in particular the release in which they were actually included, especially when closing tickets.

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
4 participants
@embray @vbraun @slel @fchapoton