Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix comparison of constants #27812

Closed
fchapoton opened this issue May 11, 2019 · 11 comments
Closed

py3: fix comparison of constants #27812

fchapoton opened this issue May 11, 2019 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

of pi < pi in particular

CC: @tscrim @rwst

Component: python3

Author: Frédéric Chapoton

Branch/Commit: b30879a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27812
@fchapoton fchapoton added this to the sage-8.8 milestone May 11, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27812

@fchapoton
Copy link
Contributor Author

New commits:

a87b644py3: improve comparison of pi with pi (for constants in general)

@fchapoton
Copy link
Contributor Author

Commit: a87b644

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented May 12, 2019

comment:3

Is there a reason why equality is a separate variable and not just part of the if statement?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2019

Changed commit from a87b644 to b30879a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

b30879adetail

@fchapoton
Copy link
Contributor Author

comment:5

indeed, fixed

@tscrim
Copy link
Collaborator

tscrim commented May 12, 2019

comment:6

Thank you. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 12, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 17, 2019

Changed branch from u/chapoton/27812 to b30879a

@vbraun vbraun closed this as completed in fe1c495 May 17, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton