Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix a flaky doctest in multipoly element #27768

Closed
fchapoton opened this issue May 4, 2019 · 7 comments
Closed

py3: fix a flaky doctest in multipoly element #27768

fchapoton opened this issue May 4, 2019 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

by refactoring a function.

This is strangely in the global namespace. Can we nevertheless change the behaviour by only returning the first output ?

CC: @tscrim @videlec

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 0db6b0d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27768
@fchapoton fchapoton added this to the sage-8.8 milestone May 4, 2019
@fchapoton
Copy link
Contributor Author

Commit: 0db6b0d

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27768

@fchapoton
Copy link
Contributor Author

New commits:

0db6b0dpy3: fix a doctest in multi_polynomial_element (refactoring)

@fchapoton

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented May 6, 2019

comment:2

Since this is not causing any doctests to fail, it seems like it was not being used in the library code. Hopefully nothing breaks in the wild, but it is a strange little function...

@tscrim
Copy link
Collaborator

tscrim commented May 6, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 8, 2019

Changed branch from u/chapoton/27768 to 0db6b0d

@vbraun vbraun closed this as completed in b7f85e7 May 8, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton