Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package e-antic #27682

Closed
videlec opened this issue Apr 16, 2019 · 37 comments
Closed

upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package e-antic #27682

videlec opened this issue Apr 16, 2019 · 37 comments

Comments

@videlec
Copy link
Contributor

videlec commented Apr 16, 2019

New release of Normaliz is available.

It depends on an additional library e-antic that is packaged in this ticket.

Tarballs

follow up tickets: #25091, #25097

(see also the meta-ticket #22420)


Step by step instructions if you want to try it out

  1. Go to the Sage source tree and pull the branch associated to this ticket

  2. Get the e-antic and normaliz tarballs and put them in the upstream repository

$ wget -P upstream https://github.com/Normaliz/Normaliz/releases/download/v3.7.1/normaliz-3.7.1.tar.gz
$ wget -P upstream http://www.labri.fr/perso/vdelecro/e-antic/e-antic-0.1.3b0.tar.gz
$ wget -P upstream https://files.pythonhosted.org/packages/69/74/a32187f49a2524978d9bc6f704049d8021b555abe3b71aa74b687a958217/PyNormaliz-2.1.tar.gz
  1. Compile and install everything
$ sage -i pynormaliz
  1. Run make
$ make build

CC: @w-bruns @jplab @sebasguts @mkoeppe

Component: packages: optional

Author: Vincent Delecroix, Matthias Koeppe

Branch/Commit: 64f1f19

Reviewer: Jean-Philippe Labbé, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27682

@videlec videlec added this to the sage-8.8 milestone Apr 16, 2019
@videlec
Copy link
Contributor Author

videlec commented Apr 16, 2019

Branch: u/vdelecroix/27682

@videlec
Copy link
Contributor Author

videlec commented Apr 16, 2019

Commit: 6e96a5a

@videlec

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

7618ea9package e-antic

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2019

Changed commit from 6e96a5a to 7618ea9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

d752708upgrade normaliz

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2019

Changed commit from 7618ea9 to d752708

@videlec

This comment has been minimized.

@videlec videlec changed the title upgrade normaliz to 3.7.0 upgrade normaliz to 3.7.0, pynormaliz to ? and package e-antic Apr 16, 2019
@jplab

This comment has been minimized.

@jplab
Copy link
Contributor

jplab commented Apr 17, 2019

comment:7

So far, both packages install without issues on debian stretch with gcc 6.3.0. Waiting for the tarball for the new version of pynormaliz.

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 17, 2019

Changed commit from d752708 to 4eb02f8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 17, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

4eb02f8fix doctest in backend_normaliz.py

@videlec

This comment has been minimized.

@jplab
Copy link
Contributor

jplab commented Apr 22, 2019

comment:12

After a make distclean and proper reinstall as the ticket description, I got everything back in order and all tests pass in the folder polyhedron.

@videlec
Copy link
Contributor Author

videlec commented Apr 22, 2019

comment:13

Replying to @jplab:

After a make distclean and proper reinstall as the ticket description, I got everything back in order and all tests pass in the folder polyhedron.

Then could you try to reproduce #22, #23, #26, #27? (and report back on the github issues)

@jplab
Copy link
Contributor

jplab commented Apr 23, 2019

comment:14

Replying to @videlec:

Replying to @jplab:

After a make distclean and proper reinstall as the ticket description, I got everything back in order and all tests pass in the folder polyhedron.

Then could you try to reproduce #22, #23, #26, #27? (and report back on the github issues)

Just to confirm: all 4 issues are now solved in sage (some of them had different traces inside of sage...).

and

$ sage -t *.py --optional=dochtml,e_antic,gfortran,memlimit,mpir,normaliz,python2,sage,pynormaliz
Using --optional=dochtml,e_antic,gfortran,memlimit,mpir,normaliz,pynormaliz,python2,sage
Doctesting 25 files.
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2019

Changed commit from 4eb02f8 to e5c669d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eaa4584package e-antic 0.1.3b0
e5c669dupgrade normaliz

@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

comment:18

Please no force pushs... I'm merging this ticket in #25097...

@videlec
Copy link
Contributor Author

videlec commented Apr 25, 2019

comment:19

sorry... won't do anymore.

@videlec
Copy link
Contributor Author

videlec commented Apr 25, 2019

comment:20

On the other hand, it does not make much sense to merge anywhere. Normaliz and e-antic needs upgrade and PyNormaliz needs to be fixed and released.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

comment:21

Yes, of course I'm waiting for these upgrades.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title upgrade normaliz to 3.7.0, pynormaliz to ? and package e-antic upgrade normaliz to 3.7.1, pynormaliz to 2.1 and package e-antic Apr 25, 2019
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

Changed branch from u/vdelecroix/27682 to u/mkoeppe/27682

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

Changed author from Vincent Delecroix to Vincent Delecroix, Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

comment:26

Updated. Builds and tests OK on macOS Mojave


New commits:

14d6c83Update normaliz to 3.7.1, pynormaliz to 2.1
64f1f19fix doctest in backend_normaliz.py

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 25, 2019

Changed commit from e5c669d to 64f1f19

@jplab
Copy link
Contributor

jplab commented Apr 25, 2019

comment:27

Builds and tests (polyhedron and thematic_tutorial folders) Oll Korrekt on debian stretch.

@tscrim
Copy link
Collaborator

tscrim commented Apr 25, 2019

comment:28

It passes all tests for me (in particular, in the folder I care about: combinat/rigged_configurations ;)). I am also getting around a 5-10% speedup in my tests:

sage: RC = RiggedConfigurations(['E',8,1], [[4,1]])
sage: %time len(RC.kleber_tree())
CPU times: user 2.29 s, sys: 8.24 ms, total: 2.3 s
Wall time: 352 ms
87
sage: RC = RiggedConfigurations(['E',8,1], [[4,1],[2,1]])
sage: %time len(RC.kleber_tree())
CPU times: user 53.4 s, sys: 52.1 ms, total: 53.5 s
Wall time: 7.68 s
2137
sage: RC = RiggedConfigurations(['F',4,1], [[3,2],[2,2]])
sage: %time len(RC.kleber_tree())
CPU times: user 9.18 s, sys: 20.3 ms, total: 9.2 s
Wall time: 1.85 s
1257

vs before

sage: RC = RiggedConfigurations(['E',8,1], [[4,1]])
sage: %time len(RC.kleber_tree())
CPU times: user 2.29 s, sys: 7.74 ms, total: 2.29 s
Wall time: 360 ms
87
sage: RC = RiggedConfigurations(['E',8,1], [[4,1],[2,1]])
sage: %time len(RC.kleber_tree())
CPU times: user 55.7 s, sys: 59.4 ms, total: 55.8 s
Wall time: 8.23 s
2137
sage: RC = RiggedConfigurations(['F',4,1], [[3,2],[2,2]])
sage: %time len(RC.kleber_tree())
CPU times: user 9.43 s, sys: 24 ms, total: 9.45 s
Wall time: 1.92 s
1257

@tscrim
Copy link
Collaborator

tscrim commented Apr 25, 2019

Reviewer: Jean-Philippe Labbé, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 29, 2019

Changed branch from u/mkoeppe/27682 to 64f1f19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants