py3: finite state machines

[dkrenn]

Fix the remaining Py3 issues in sage.combinat.finite_state_machine

Depends on #27667

CC: @fchapoton

Component: python3

Author: Daniel Krenn

Branch/Commit: 3b1d45f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27679

[dkrenn]

Branch: u/dkrenn/fsm-py3

[dkrenn]

Commit: 3b1d45f

[dkrenn]

comment:2

Py3 issues fixed

---

New commits:

f5f8938	pretty for fsm
1693057	Trac #27667: remove todo
a21c793	Trac #27667: realign doctest output
0f53650	fix sorting in full_group_by
01b5429	minor code rewrite (PEP8 etc) in full_group_by
47c8358	fix doctests (changed ordering of labels)
3b1d45f	fix exception handling of preview_word

[dkrenn]

Dependencies: #27667

[dkrenn]

comment:3

0f53650	fix sorting in full_group_by
47c8358	fix doctests (changed ordering of labels)

The output seems to be unstable in Python3, therefore a sorting is introduced. This is kind of cheap as the strings of the keys are determined anyway.

01b5429	minor code rewrite (PEP8 etc) in full_group_by

Non-Py3 related.

3b1d45f	fix exception handling of preview_word

This seems to be indeed the reason of https://www.python.org/dev/peps/pep-0479/#rationale, although in our case it was used intentional. However, after reading the PEP, the current behavior for preview_word can be considered as a bug, so the exception was changed (and other code adapted). Now everthing works out fine.

[tscrim]

comment:4

LGTM (there is no way I see the failure on the patchbot as being related to this ticket).

Frédéric, I am cc-ing you just so you are aware of this ticket.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/dkrenn/fsm-py3 to 3b1d45f