Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 doctests in padic_lattice_element.py #27612

Closed
jhpalmieri opened this issue Apr 5, 2019 · 10 comments
Closed

Py3 doctests in padic_lattice_element.py #27612

jhpalmieri opened this issue Apr 5, 2019 · 10 comments

Comments

@jhpalmieri
Copy link
Member

Fix the Python 3 doctests in this file.

Component: python3

Author: John Palmieri

Branch: 0dba3b0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27612

@jhpalmieri jhpalmieri added this to the sage-8.8 milestone Apr 5, 2019
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/lattice_element

@jhpalmieri
Copy link
Member Author

Commit: 0dba3b0

@jhpalmieri
Copy link
Member Author

New commits:

0dba3b0trac 27612: Fix Python 3 doctests for padic_lattice_element.py

@jhpalmieri
Copy link
Member Author

comment:3

For reasons I don't understand (see https://groups.google.com/d/msg/sage-devel/r7Q7XpL_bgY/1P7BOYzNBgAJ), with Python 2, the different functions ZpLC(2), ZpLF(2), and a few others all produce deprecation warnings when run at the command line, but there is just a single deprecation warning (printed for the first function and not the rest) when running doctests. With Python 3, the behavior is the same for doctests and at the command line.

@fchapoton
Copy link
Contributor

comment:4

ok, good enough for the moment, even if it only cures symptoms

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Apr 8, 2019

Changed branch from u/jhpalmieri/lattice_element to 0dba3b0

@jhpalmieri
Copy link
Member Author

comment:6

Do we need to undo this change? This is now failing for me, maybe because of the upgrade in the version of Python 3.

@jhpalmieri
Copy link
Member Author

Changed commit from 0dba3b0 to none

@jhpalmieri
Copy link
Member Author

comment:7

Never mind, it's working for me now. I don't know what was going on before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants