-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: fix all doctests in schemes/product_projective #27449
Comments
Branch: u/chapoton/27449 |
Commit: |
New commits:
|
comment:2
green bot, please review |
Reviewer: Travis Scrimshaw |
comment:3
It turns out that it is actually faster to do a
For a double, there ends up being not much noticable difference:
I am not saying that anything needs to be changed (I actually like the simplicity of returning the generator), just pointing out some timings (this probably does not need to be super optimized anyways). So LGTM. |
Changed branch from u/chapoton/27449 to |
by adding a missing
__len__
method.plus some light code cleanup.
Component: python3
Author: Frédéric Chapoton
Branch/Commit:
9440e0a
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/27449
The text was updated successfully, but these errors were encountered: