Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix misc/unittest #27431

Closed
fchapoton opened this issue Mar 6, 2019 · 7 comments
Closed

py3: fix misc/unittest #27431

fchapoton opened this issue Mar 6, 2019 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

where the empty-set-of-Exception was done using None

plus full pep8 cleanup of the modified file

Component: python3

Author: Frédéric Chapoton

Branch/Commit: c048c3a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27431
@fchapoton fchapoton added this to the sage-8.7 milestone Mar 6, 2019
@fchapoton
Copy link
Contributor Author

New commits:

c048c3afix misc/unittest (wrong no-Exception handling)

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

Commit: c048c3a

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27431

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2019

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 8, 2019

Changed branch from u/chapoton/27431 to c048c3a

@vbraun vbraun closed this as completed in 769697a Mar 8, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton