Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce_dict deprecations and documention updates #27353

Closed
nbruin opened this issue Feb 25, 2019 · 8 comments
Closed

Coerce_dict deprecations and documention updates #27353

nbruin opened this issue Feb 25, 2019 · 8 comments
Labels
p: minor / 4 t: bug
Milestone
sage-8.7

Comments

@nbruin
Copy link
Contributor

nbruin commented Feb 25, 2019

Following up on #24135: deprecations. Some minor issues with documentation that was out of date as well.

Component: misc

Author: Nils Bruin

Branch: 00e8e75

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/27353
@nbruin nbruin added this to the sage-8.7 milestone Feb 25, 2019
@nbruin
Copy link
Contributor Author

nbruin commented Feb 25, 2019

Branch: u/nbruin/coerce_dict_cleanup

@nbruin
Copy link
Contributor Author

nbruin commented Feb 25, 2019

New commits:

00e8e75resolve deprecations and some minor documentation updates (lagging from a long time ago)

@nbruin
Copy link
Contributor Author

nbruin commented Feb 25, 2019

Commit: 00e8e75

@jdemeyer
Copy link
Contributor

Reviewer: Jeroen Demeyer

@slel

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Feb 28, 2019

Changed branch from u/nbruin/coerce_dict_cleanup to 00e8e75

@vbraun vbraun closed this as completed in f8252a7 Feb 28, 2019
@jdemeyer
Copy link
Contributor

jdemeyer commented Apr 9, 2019

Changed commit from 00e8e75 to none

@jdemeyer
Copy link
Contributor

jdemeyer commented Apr 9, 2019

comment:6

Technically speaking, these deprecations from #24135 shouldn't have been removed yet as they were not 1 year in a released version. but it's probably not an issue in practice. I'm removing more #24135 deprecations in #27627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
4 participants
@vbraun @nbruin @slel @jdemeyer