Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: some tiny fixes in numerical folder #27342

Closed
fchapoton opened this issue Feb 24, 2019 · 8 comments
Closed

py3: some tiny fixes in numerical folder #27342

fchapoton opened this issue Feb 24, 2019 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@fchapoton
Copy link
Contributor

Component: python3

Author: Frédéric Chapoton

Branch/Commit: ba61c9e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27342
@fchapoton fchapoton added this to the sage-8.7 milestone Feb 24, 2019
@fchapoton
Copy link
Contributor Author

New commits:

ba61c9epy3: some tiny fixes in numerical folder

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27342

@fchapoton
Copy link
Contributor Author

Commit: ba61c9e

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2019

comment:2

I don't have the Python3 version to test, but I do not think this change is necessary from looking at the code:

-            sage: p.add_col(range(5), range(5))
+            sage: p.add_col(list(range(5)), list(range(5)))

Even if it does fail, I think it would be better to have the original input work.
Otherwise LGTM.

@fchapoton
Copy link
Contributor Author

comment:3

Thanks for the review. The type "list" is hardcoded (in the cdef line) for both entries of this function. This could be enhanced, but not now.

@tscrim
Copy link
Collaborator

tscrim commented Feb 25, 2019

comment:4

Ah, I see. I missed that. Sorry for the noise.

@vbraun
Copy link
Member

vbraun commented Feb 28, 2019

Changed branch from u/chapoton/27342 to ba61c9e

@vbraun vbraun closed this as completed in ce983fe Feb 28, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton