Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: Fix plot module for python3 #27126

Closed
vinklein mannequin opened this issue Jan 25, 2019 · 6 comments
Closed

py3: Fix plot module for python3 #27126

vinklein mannequin opened this issue Jan 25, 2019 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jan 25, 2019

The root cause for matplotlib's AttributeError: Unknown property which was testing hasattr(x, '__iter__') to filter str. str hasn't an __iter__ method in py2 but has one in py3.

Component: python3

Author: Vincent Klein

Branch/Commit: 2131766

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27126
@vinklein vinklein mannequin added this to the sage-8.7 milestone Jan 25, 2019
@vinklein vinklein mannequin added c: python3 labels Jan 25, 2019
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jan 25, 2019

Branch: u/vklein/27126

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jan 25, 2019

New commits:

2131766Trac #27126: Fix plot module for python3

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jan 25, 2019

Commit: 2131766

@vinklein vinklein mannequin added the s: needs review label Jan 25, 2019
@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2019

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 27, 2019

Changed branch from u/vklein/27126 to 2131766

@vbraun vbraun closed this as completed in 227cfa6 Jan 27, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
2 participants
@vbraun @tscrim