py3: final fix for species

[fchapoton]

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: aba9cd9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27072

[fchapoton]

Commit: 0d4a597

[fchapoton]

Branch: u/chapoton/27072

[fchapoton]

New commits:

0d4a597

py3: final fix for species

[fchapoton]

comment:2

green bot (damn bot with no pyflakes..), please review

[tscrim]

comment:3

Perhaps it would be better to have min=0 be the default, and so we can change this test:

-        if ((min is None and max is None) or
-            (max is None and self.get_aorder() >= min)):
+        if (max is None and (not min or self.get_aorder() >= min)):
             return self

[sagetrac-git]

Changed commit from 0d4a597 to b579370

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b579370

fix

[fchapoton]

comment:5

done, thanks

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:6

Thank you.

[vbraun]

comment:7

Numerous doctest failures...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

acf0b7a

py3: final fix for species

[sagetrac-git]

Changed commit from b579370 to acf0b7a

[fchapoton]

comment:9

indeed. Let us step back to my basic but working fix.

[tscrim]

comment:10

Dumb thing, but this change makes it overindented:

-            (max is None and self.get_aorder() >= min)):
-            return self
+             (max is None and self.get_aorder() >= min)):
+             return self

Once fixed and green bot (either before or after), you can set back to a positive review.

[sagetrac-git]

Changed commit from acf0b7a to aba9cd9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aba9cd9

py3: final fix for species

[fchapoton]

comment:12

right. Done. I will re-launch my bot on it.

[fchapoton]

comment:13

ok, one green bot (the other is broken)

[vbraun]

Changed branch from u/chapoton/27072 to aba9cd9