Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: some work on modular/modform_hecketriangle/ #26967

Closed
fchapoton opened this issue Dec 29, 2018 · 13 comments
Closed

py3: some work on modular/modform_hecketriangle/ #26967

fchapoton opened this issue Dec 29, 2018 · 13 comments

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: e765ca6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26967

@fchapoton fchapoton added this to the sage-8.7 milestone Dec 29, 2018
@fchapoton
Copy link
Contributor Author

New commits:

fc1bea7py3: some work on modular/modform_hecketriangle/

@fchapoton
Copy link
Contributor Author

Commit: fc1bea7

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26967

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2018

Changed commit from fc1bea7 to 580be8f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

580be8fharden one doctest in modform_hecketriangle

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e765ca6py3: some work on modular/modform_hecketriangle/

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2018

Changed commit from 580be8f to e765ca6

@fchapoton
Copy link
Contributor Author

comment:4

green bot, please review.

I have some doubts on the use of SagePrettyPrinter instead of pprint.pformat. In particular, one is forced to import the necessary stuff inside the _repr_ to avoid importing IPython at startup. But Volker said once that one should avoid pprint.pformat, without telling what to do instead.

@tscrim
Copy link
Collaborator

tscrim commented Dec 30, 2018

comment:5

From #26628, it seems that SagePrettyPrinter is not working either. So I want to wait on this ticket until we can figure out #26628.

@fchapoton
Copy link
Contributor Author

comment:6

I would argue that here we will only use the pretty printer on a dict with keys all of the same nature (elements in the same ring), hence that should always be comparable. So it should be ok.

The phenomenon of impredictibility seen in #26628 comes from the comparison of letters and numbers.

Would you prefer to use pprint.pformat ?

@tscrim
Copy link
Collaborator

tscrim commented Jan 1, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 1, 2019

comment:7

No, this will be fine.

@vbraun
Copy link
Member

vbraun commented Jan 23, 2019

Changed branch from u/chapoton/26967 to e765ca6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants