Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: care for Schnyder woods #26918

Closed
fchapoton opened this issue Dec 19, 2018 · 11 comments
Closed

py3: care for Schnyder woods #26918

fchapoton opened this issue Dec 19, 2018 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.6

Comments

@fchapoton
Copy link
Contributor

by not mixing integers and letters as vertices of graphs there

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 43e5f64

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26918
@fchapoton fchapoton added this to the sage-8.6 milestone Dec 19, 2018
@fchapoton
Copy link
Contributor Author

Commit: 87cdeb7

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26918

@fchapoton
Copy link
Contributor Author

New commits:

87cdeb7py3: caring for Schnyder woods

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

0ff511btrac 26918 fix wrong relabelling of embeddings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2018

Changed commit from 87cdeb7 to 0ff511b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

43e5f64trac 26918 fix wrong relabelling of embeddings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2018

Changed commit from 0ff511b to 43e5f64

@fchapoton
Copy link
Contributor Author

comment:5

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Dec 21, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 21, 2018

comment:6

While I do not strictly like sweeping the issue under the rug, we should make some progress here as graphs still needs a lot of work.

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from u/chapoton/26918 to 43e5f64

@vbraun vbraun closed this as completed in 0f5b17e Dec 23, 2018
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton