py3: Make doctest pass in combinat/rigged_configurations module

[vinklein]

This ticket fix the last py3 failures in combinat/rigged_configurations module.

For the TypeError: unsupported format string passed to sage.rings.rational.Rational.__format__ another approach is to implement a __format__ method in sage.rings.rational.Rational, unfortunately it will not solve the cases with NoneType. For this reason i think string formatting support for sage's Rational should be done in another ticket if needed.

CC: @fchapoton

Component: python3

Author: Vincent Klein

Branch/Commit: 8596208

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26805

[vinklein]

Author: Vincent Klein

[vinklein]

Branch: u/vklein/26805

[vinklein]

Commit: bbb1dc1

[fchapoton]

comment:4

ok, good to go. But would you please first fix the pyflakes warnings ?

[fchapoton]

Reviewer: Frédéric Chapoton

[vinklein]

comment:5

Sure, i will do it this morning.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8596208

Trac #26805: Remove useless assignement

[sagetrac-git]

Changed commit from bbb1dc1 to 8596208

[vinklein]

comment:7

@fchapoton I commented vct rather than deleting the line to keep consistency with
the comments below in the code.
Do you think the comments

        # vct = self.parent()._folded_ct
        # sigma = vct.folding_orbit()
        # gammatilde = list(vct.scaling_factors())
        # gammatilde[-1] = 2

are helpful or do you think we should delete them?

[fchapoton]

comment:8

oh, we can keep them.

green bot => positive review.

Do you have a patchbot at your disposal that you could launch on this ticket ? Mines are already busy right now.

[vinklein]

comment:9

Not right now (some computing in progress). I will try this afternoon.

[vbraun]

Changed branch from u/vklein/26805 to 8596208

[embray]

comment:13

This tickets were closed as fixed after the Sage 8.5 release.