Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: more fixes for KR crystals #26778

Closed
fchapoton opened this issue Nov 27, 2018 · 7 comments
Closed

py3: more fixes for KR crystals #26778

fchapoton opened this issue Nov 27, 2018 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 7dd6c18

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/26778
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 27, 2018
@fchapoton
Copy link
Contributor Author

New commits:

7dd6c18py3: more fixes for Kirillov Reshetikhin and crystals

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26778

@fchapoton
Copy link
Contributor Author

Commit: 7dd6c18

@vinklein
Copy link
Mannequin

vinklein mannequin commented Nov 27, 2018

Reviewer: Vincent Klein

@vinklein
Copy link
Mannequin

vinklein mannequin commented Nov 27, 2018

comment:2

Nice! It look likes it fix more than 40 doctests failures in combinat.rigged_configurations module.

Green bot => positive review

@fchapoton
Copy link
Contributor Author

comment:3

ok, thanks

@vbraun
Copy link
Member

vbraun commented Nov 30, 2018

Changed branch from u/chapoton/26778 to 7dd6c18

@vbraun vbraun closed this as completed in 1b87a1d Nov 30, 2018
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
2 participants
@vbraun @fchapoton