Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: some care for matroids #26767

Closed
fchapoton opened this issue Nov 26, 2018 · 10 comments
Closed

py3: some care for matroids #26767

fchapoton opened this issue Nov 26, 2018 · 10 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

by changing the way the repr is sorted.

CC: @sagetrac-Stefan @sagetrac-Rudi @sagetrac-zgershkoff

Component: python3

Author: Frédéric Chapoton

Branch/Commit: ee88d36

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26767
@fchapoton fchapoton added this to the sage-8.5 milestone Nov 26, 2018
@fchapoton
Copy link
Contributor Author

Commit: 50bf0ad

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26767

@fchapoton
Copy link
Contributor Author

New commits:

816bc5cpy3: some fixes for matroids
50bf0adfixing many doctests in matroids (change of repr for py3)

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

comment:4

Could you reintroduce breaks into the long line outputs? Otherwise LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

ee88d36trac 26767 cutting the doctests at 80 colons

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 27, 2018

Changed commit from 50bf0ad to ee88d36

@fchapoton
Copy link
Contributor Author

comment:6

ok, done and double checked.

@tscrim
Copy link
Collaborator

tscrim commented Nov 27, 2018

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented Nov 29, 2018

Changed branch from u/chapoton/26767 to ee88d36

@vbraun vbraun closed this as completed in 92b46cd Nov 29, 2018
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton