-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: cleanup of toy d basis #26670
Comments
New commits:
|
Branch: u/chapoton/26670 |
Commit: |
comment:2
bot is morally green. There is one potentially controversial change, sage: gb = d_basis(I); gb
- [z - 107196348594952664476180297953816049406949517534824683390654620424703403993052759002989622,
- y + 84382748470495086324437828161121754084154498572003307352857967748090984550697850484197972764799434672877850291328840,
- x + 105754645239745824529618668609551113725317621921665293762587811716173,
- 282687803443]
+ [z ..., y ..., x ..., 282687803443] where the important part of the result is the last integer. The 3 previous linear polynomials are only unique modulo this integer, and random otherwise. |
Reviewer: Travis Scrimshaw |
comment:4
I think this change is fine. It shows a little bit more of what is important for that test and makes the test look cleaner. |
Changed branch from u/chapoton/26670 to |
plus full pep cleanup
CC: @tscrim
Component: python3
Author: Frédéric Chapoton
Branch/Commit:
05b18cd
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/26670
The text was updated successfully, but these errors were encountered: