Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py3: Fix DeprecationWarning: generator X raised StopIteration #26466

Closed
vinklein mannequin opened this issue Oct 11, 2018 · 14 comments
Closed

Py3: Fix DeprecationWarning: generator X raised StopIteration #26466

vinklein mannequin opened this issue Oct 11, 2018 · 14 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented Oct 11, 2018

Following #26458 this ticket aim at fixing the remaining cases of
DeprecationWarning: generator X raised StopIteration in sage.

Component: python3

Keywords: thursdaysbdx

Author: Vincent Klein

Branch/Commit: 9da555b

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26466
@vinklein vinklein mannequin added this to the sage-8.4 milestone Oct 11, 2018
@vinklein vinklein mannequin added c: python3 labels Oct 11, 2018
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

Branch: u/vklein/26466

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

Commit: 9da555b

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

Changed keywords from none to #thursdaysbdx

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

New commits:

9da555bTrac #26466: Fix some Deprecation warning for generator ...

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

Changed keywords from #thursdaysbdx to thursdaysbdx

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 11, 2018

Author: Vincent Klein

@fchapoton
Copy link
Contributor

comment:5

is this ready for review ?

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 12, 2018

comment:6

Not really i still have one more case i try to solve.

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 12, 2018

comment:7

That being said you can make review/comments for what it's done by 9da555b commit.

@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Oct 12, 2018

comment:8

Well i'm still not sure what the right thing to do for "generator" '_FSMTapeCache_.preview_word.<locals>.<genexpr>' it seems to me that raise StopIteration is misused here in the first place as preview_word is not a proper generator nor an iterator. I need a better understanding of _FSMTapeCache_ before fixing this.

The preview_word case will not be fixed in this ticket.

@vinklein vinklein mannequin added the s: needs review label Oct 12, 2018
@fchapoton
Copy link
Contributor

comment:9

ok, then good to go.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

Changed branch from u/vklein/26466 to 9da555b

@vbraun vbraun closed this as completed in 9a0815d Oct 20, 2018
@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:11

This should be re-targeted for 8.5.

@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@embray @vbraun @fchapoton