Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: fix some doctests in game_theory #26429

Closed
fchapoton opened this issue Oct 7, 2018 · 12 comments
Closed

py3: fix some doctests in game_theory #26429

fchapoton opened this issue Oct 7, 2018 · 12 comments

Comments

@fchapoton
Copy link
Contributor

Component: python3

Author: Frédéric Chapoton

Branch/Commit: bb0122e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26429

@fchapoton fchapoton added this to the sage-8.4 milestone Oct 7, 2018
@fchapoton
Copy link
Contributor Author

New commits:

b104467py3: fixing some doctests in game_theory/

@fchapoton
Copy link
Contributor Author

Commit: b104467

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26429

@tscrim
Copy link
Collaborator

tscrim commented Oct 7, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 7, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 20, 2018

comment:3
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 437, in sage.game_theory.normal_form_game
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities: {(0, 1): [2.0, 10.0], (1, 0): [10.0, 2.0], (0, 0): [8.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [8.0, 8.0],
     (0, 1): [2.0, 10.0],
     (1, 0): [10.0, 2.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 719, in sage.game_theory.normal_form_game.NormalFormGame.__init__
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities: {(0, 1): [2.0, 11.0], (1, 0): [10.0, 7.0], (0, 0): [5.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [5.0, 8.0],
     (0, 1): [2.0, 11.0],
     (1, 0): [10.0, 7.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 979, in sage.game_theory.normal_form_game.NormalFormGame._gambit_game
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities:
     {(0, 1): [2.0, 10.0], (1, 0): [10.0, 2.0],
      (0, 0): [8.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [8.0, 8.0],
     (0, 1): [2.0, 10.0],
     (1, 0): [10.0, 2.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
3 items had failures:
   1 of 151 in sage.game_theory.normal_form_game
   1 of  51 in sage.game_theory.normal_form_game.NormalFormGame.__init__
   1 of  14 in sage.game_theory.normal_form_game.NormalFormGame._gambit_game
    [665 tests, 3 failures, 2.16 s]
----------------------------------------------------------------------
sage -t src/sage/game_theory/normal_form_game.py  # 3 doctests failed
----------------------------------------------------------------------

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Changed commit from b104467 to bb0122e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

adf03e9Merge branch 'u/chapoton/26429' in 8.4
bb0122etrac 26429 fixing gambit optional doctests

@fchapoton
Copy link
Contributor Author

comment:5

fixed the gambit optional doctests

@fchapoton
Copy link
Contributor Author

comment:6

bot is morally green, please review

@vbraun
Copy link
Member

vbraun commented Oct 22, 2018

Changed branch from u/chapoton/26429 to bb0122e

@embray
Copy link
Contributor

embray commented Oct 28, 2018

comment:9

This should be re-targeted for 8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants