Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sort inductive valuations #25226

Closed
saraedum opened this issue Apr 22, 2018 · 18 comments
Closed

Do not sort inductive valuations #25226

saraedum opened this issue Apr 22, 2018 · 18 comments

Comments

@saraedum
Copy link
Member

Currently, the following fails in https://github.com/MCLF/henselization

sage: from henselization import *
sage: K = QQ.henselization(5)
sage: R.<x> = K[]
sage: F = (x^2 + 1).factor()

The problem is an obvious sort=False that is missing in the valuation framework, i.e., factorizations get sorted (for no good reason) but some of the element in the henselization namespace do not support sorting.

I can't really write a doctest for this. There are no rings that support the valuation framework but can not decide equality (say lazy p-adics) in Sage yet. It's kind of obvious that sort=False should be there just like everywhere else in that file.

CC: @roed314

Component: padics

Keywords: padicIMA

Author: Julian Rüth

Branch/Commit: d988e9f

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25226

@saraedum saraedum added this to the sage-8.2 milestone Apr 22, 2018
@saraedum
Copy link
Member Author

Branch: u/saraedum/maclane-sort

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2018

Commit: b92569b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

bb1a407Fix incorrect @echo command
52c2136ignoring more chatter during docbuild
f3bfa5fUpgraded .gitlab-ci.yml to provide proper tags that actually work
5719a72Improve caching during build
e4887e9Fix caching during build
be3a0f7The docbuild crashes happen during an os.fork to spawn tachyon
7d85dc7Something related to the sphinxbuild seems to be leaking memory
50898feTry to build-from-scratch on GitLab's underpowered CI machines
95c6275Comment on fork logic in docbuilding
b92569bMerge remote-tracking branch 'trac/u/saraedum/gitlabci' into maclane-sort

@saraedum
Copy link
Member Author

Dependencies: #24655

@saraedum
Copy link
Member Author

Last 10 new commits:

bb1a407Fix incorrect @echo command
52c2136ignoring more chatter during docbuild
f3bfa5fUpgraded .gitlab-ci.yml to provide proper tags that actually work
5719a72Improve caching during build
e4887e9Fix caching during build
be3a0f7The docbuild crashes happen during an os.fork to spawn tachyon
7d85dc7Something related to the sphinxbuild seems to be leaking memory
50898feTry to build-from-scratch on GitLab's underpowered CI machines
95c6275Comment on fork logic in docbuilding
b92569bMerge remote-tracking branch 'trac/u/saraedum/gitlabci' into maclane-sort

@saraedum

This comment has been minimized.

@saraedum
Copy link
Member Author

Changed commit from b92569b to none

@saraedum
Copy link
Member Author

Changed branch from u/saraedum/maclane-sort to none

@saraedum
Copy link
Member Author

Changed dependencies from #24655 to none

@saraedum
Copy link
Member Author

Branch: u/saraedum/25226

@saraedum
Copy link
Member Author

New commits:

d988e9fDo not sort inductive valuations

@saraedum
Copy link
Member Author

Commit: d988e9f

@saraedum
Copy link
Member Author

Work Issues: is the patchbot happy?

@saraedum
Copy link
Member Author

saraedum commented Jul 4, 2018

Changed work issues from is the patchbot happy? to none

@roed314
Copy link
Contributor

roed314 commented Jul 22, 2018

Changed keywords from none to padicIMA

@roed314
Copy link
Contributor

roed314 commented Jul 30, 2018

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Jul 30, 2018

comment:12

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Aug 11, 2018

Changed branch from u/saraedum/25226 to d988e9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants