-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not sort inductive valuations #25226
Comments
Branch: u/saraedum/maclane-sort |
Commit: |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Dependencies: #24655 |
Last 10 new commits:
|
This comment has been minimized.
This comment has been minimized.
Changed commit from |
Changed branch from u/saraedum/maclane-sort to none |
Changed dependencies from #24655 to none |
Branch: u/saraedum/25226 |
New commits:
|
Commit: |
Work Issues: is the patchbot happy? |
Changed work issues from is the patchbot happy? to none |
Changed keywords from none to padicIMA |
Reviewer: David Roe |
comment:12
Looks good to me. |
Changed branch from u/saraedum/25226 to |
Currently, the following fails in https://github.com/MCLF/henselization
The problem is an obvious
sort=False
that is missing in the valuation framework, i.e., factorizations get sorted (for no good reason) but some of the element in the henselization namespace do not support sorting.I can't really write a doctest for this. There are no rings that support the valuation framework but can not decide equality (say lazy p-adics) in Sage yet. It's kind of obvious that
sort=False
should be there just like everywhere else in that file.CC: @roed314
Component: padics
Keywords: padicIMA
Author: Julian Rüth
Branch/Commit:
d988e9f
Reviewer: David Roe
Issue created by migration from https://trac.sagemath.org/ticket/25226
The text was updated successfully, but these errors were encountered: