-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not mangle Python stack traces in sphinx-build #25160
Comments
Branch: u/saraedum/sphinxbuild-stack |
Commit: |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
I think it would be better to write |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Jeroen Demeyer |
Changed branch from u/saraedum/sphinxbuild-stack to |
Changed commit from |
comment:15
Breakage at #27073. |
NOTE: doctests ignore whitespace, so this test doesn't actually test the indentation anyway. |
This upstreams part of Debian's
u2-better-sphinx-failure-modes.patch
by Ximin Luo: we should not.strip()
the lines that come out of Sphinx because this breaks indent in stack traces. Instead we should onlyrstrip()
to remove the trailing newline.After this one line change, I also wanted to make this doctestable, so I had to remove the global variable (which at least to me feels like a hack anyway.)
Finally, I added a copyright header sourced from the git log.
CC: @infinity0
Component: doctest framework
Author: Julian Rüth
Branch:
67aff77
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/25160
The text was updated successfully, but these errors were encountered: