Skip to content

get rid of CombinatorialClass in Necklaces #24485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fchapoton opened this issue Jan 7, 2018 · 10 comments
Closed

get rid of CombinatorialClass in Necklaces #24485

fchapoton opened this issue Jan 7, 2018 · 10 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@fchapoton
Copy link
Contributor

as part of #12913

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: cb716c9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24485
@fchapoton fchapoton added this to the sage-8.2 milestone Jan 7, 2018
@fchapoton
Copy link
Contributor Author

Commit: fbecb41

@fchapoton
Copy link
Contributor Author

New commits:

fbecb41refresh the necklaces (no more CombinatorialClass)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24485

@tscrim
Copy link
Collaborator

tscrim commented Jan 7, 2018

comment:2

Two things: __classcall_private__ needs a doctest:

sage: Necklaces([2,1,1]) is Necklaces(Composition([2,1,1]))
True

I think you should just (attempt to) convert into a Composition when content is not a Composition.

Also, I was told at some point that it is better to have UniqueRepresentation be before Parent, but I don't remember precisely why (and don't feel like you have to change it).

@tscrim
Copy link
Collaborator

tscrim commented Jan 7, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2018

Changed commit from fbecb41 to cb716c9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

cb716c9details

@fchapoton
Copy link
Contributor Author

comment:4

thanks. done

@tscrim
Copy link
Collaborator

tscrim commented Jan 7, 2018

comment:5

Thank you.

@vbraun
Copy link
Member

vbraun commented Jan 14, 2018

Changed branch from u/chapoton/24485 to cb716c9

@vbraun vbraun closed this as completed in d3a06a0 Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton