Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: remove deprecated cmpfn ; wrap key(..) in multi-polynomials #24409

Closed
fchapoton opened this issue Dec 20, 2017 · 12 comments
Closed

py3: remove deprecated cmpfn ; wrap key(..) in multi-polynomials #24409

fchapoton opened this issue Dec 20, 2017 · 12 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@fchapoton
Copy link
Contributor

as followup of #21766 and part of #16536 and #15981

CC: @embray @jdemeyer @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: a7dbdff

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/24409
@fchapoton fchapoton added this to the sage-8.2 milestone Dec 20, 2017
@fchapoton
Copy link
Contributor Author

New commits:

3f46b40py3: get rid of cmpfn to sort polynomials, plus wrap keys(..) with list

@fchapoton
Copy link
Contributor Author

Commit: 3f46b40

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24409

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@a-andre
Copy link
Contributor

a-andre commented Dec 20, 2017

comment:3

LGTM.

@a-andre
Copy link
Contributor

a-andre commented Dec 20, 2017

Reviewer: André Apitzsch

@tscrim
Copy link
Collaborator

tscrim commented Dec 20, 2017

comment:4

The keys call is redundant, so I would actually remove that altogether.

@embray
Copy link
Contributor

embray commented Dec 21, 2017

comment:5

Indeed; lines like this

E = list(self.__repn.keys())

can just be written

E = list(self.__repn)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2017

Changed commit from 3f46b40 to a7dbdff

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a7dbdfftrac 24409 removing .keys

@fchapoton
Copy link
Contributor Author

comment:7

done. Needs review

@vbraun
Copy link
Member

vbraun commented Dec 25, 2017

Changed branch from u/chapoton/24409 to a7dbdff

@vbraun vbraun closed this as completed in 3981c22 Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
5 participants
@embray @vbraun @tscrim @fchapoton @a-andre