Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make openssl a dependency for pip packages #23893

Closed
koffie opened this issue Sep 19, 2017 · 6 comments
Closed

make openssl a dependency for pip packages #23893

koffie opened this issue Sep 19, 2017 · 6 comments

Comments

@koffie
Copy link
Contributor

koffie commented Sep 19, 2017

Right now one has:

sage -i beautifulsoup
***********************************************
make[1]: Entering directory '/users/derickx/sage_patch2/build/make'
sage-logger -p 'sage --pip install beautifulsoup' /users/derickx/sage_patch2/logs/pkgs/beautifulsoup.log
[beautifulsoup] pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
[beautifulsoup] Collecting beautifulsoup
[beautifulsoup]   Could not fetch URL https://pypi.python.org/simple/beautifulsoup/: There was a problem confirming the ssl certificate: Can't connect to HTTPS URL because the SSL module is not available. - skipping
[beautifulsoup]   Could not find a version that satisfies the requirement beautifulsoup (from versions: )
[beautifulsoup] No matching distribution found for beautifulsoup
Makefile:1114: recipe for target 'beautifulsoup' failed
make[1]: *** [beautifulsoup] Error 1
make[1]: Leaving directory '/users/derickx/sage_patch2/build/make'

real    0m1.186s
user    0m0.788s
sys     0m0.040s
***************************************************************
Error building Sage.

The following package(s) may have failed to build (not necessarily
during this run of 'make beautifulsoup'):

The build directory may contain configuration files and other potentially
helpful information. WARNING: if you now run 'make' again, the build
directory will, by default, be deleted. Set the environment variable
SAGE_KEEP_BUILT_SPKGS to 'yes' to prevent this.

Makefile:16: recipe for target 'beautifulsoup' failed
make: *** [beautifulsoup] Error 1

However this does not need to fail since it succeeds after:

sage -i openssl
sage -f python2

Depends on #29291

CC: @NathanDunfield

Component: packages: optional

Reviewer: Nathan Dunfield

Issue created by migration from https://trac.sagemath.org/ticket/23893

@koffie koffie added this to the sage-8.1 milestone Sep 19, 2017
@embray
Copy link
Contributor

embray commented Jul 11, 2019

comment:1

I think what we may want to do about this is actually just make building Sage without SSL fail unless explicitly requested. See e.g. #27705

@embray embray removed this from the sage-8.1 milestone Jul 11, 2019
@slel
Copy link
Member

slel commented Oct 11, 2020

comment:3

Related:

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 13, 2021

comment:4

Outdated; with #29291 we just no longer accept python3 that does not have openssl.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 13, 2021

Dependencies: #29291

@NathanDunfield
Copy link
Contributor

Reviewer: Nathan Dunfield

@NathanDunfield
Copy link
Contributor

comment:5

Agree this outdated, setting positive review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants