-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and user interface of Fourier series #23672
Labels
Milestone
Comments
Branch: public/23672-Fourier_series |
Commit: |
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Changes documented with explanatory texts and tests. Now behaves as one expects of a Fourier series. |
comment:4
Thank you for the review! |
comment:5
Filled in "Reviewers" field. |
Reviewer: Richard L Lozes |
Changed branch from public/23672-Fourier_series to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in https://groups.google.com/forum/#!topic/sage-devel/b1pWen3lrKA, the documentation of Fourier series as implemented in piecewise-defined functions needs some improvement. This ticket provides it, as well as a simplification of the user interface: the half-period is now an optional argument; if not provided, it is inferred from the domain of the piecewise-defined function:
The ticket also corrects two bugs:
fourier_series_partial_sum
did not return SN(x) but SN-1(x) (this is because the summation was governed bysrange(1, N)
instead ofsrange(1, N+1)
); we have nowCC: @wdjoyner
Component: documentation
Keywords: Fourier series, piecewise functions
Author: Eric Gourgoulhon
Branch/Commit:
8cb8a4d
Reviewer: Richard L Lozes
Issue created by migration from https://trac.sagemath.org/ticket/23672
The text was updated successfully, but these errors were encountered: