Mark morphisms as coercions

[roed314]

Currently, DefaultCovertMaps have an attribute _is_coercion that is unused. I propose moving it up to Map and setting it when coercion maps are created.

Component: coercion

Keywords: sd86.5

Author: David Roe, Julian Rüth

Branch: 78807fa

Reviewer: Julian Rüth, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23211

[roed314]

Branch: u/roed/mark_morphisms_as_coercions

[roed314]

Changed keywords from none to sd86.5

[roed314]

New commits:

6be53f3

Move _is_coercion from DefaultConvertMap to Map and make it accurate

[roed314]

Commit: 6be53f3

[roed314]

Author: David Roe

[roed314]

comment:3

Just ran tests: they all pass.

[saraedum]

comment:4

Looks good except for one "Conversion map" that should print as a "Coercion map".

[saraedum]

Changed branch from u/roed/mark_morphisms_as_coercions to u/saraedum/mark_morphisms_as_coercions

[saraedum]

Changed author from David Roe to David Roe, Julian Rüth

[saraedum]

Reviewer: Julian Rüth

[saraedum]

Changed commit from 6be53f3 to d8eec2d

[saraedum]

New commits:

7dac7e2	Fix doctest
9a9e437	Print default "coerce" maps as "Coercion"
d8eec2d	Fixed doctests

[sagetrac-git]

Changed commit from d8eec2d to 2fa81a7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2fa81a7

Fix doctests to print exactly as they show up on screen

[roed314]

Changed reviewer from Julian Rüth to Julian Rüth, David Roe

[vbraun]

comment:10

Merge conflict

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b483c8e

Merge branch 'develop' into t/23211/mark_morphisms_as_coercions

[sagetrac-git]

Changed commit from 2fa81a7 to b483c8e

[saraedum]

comment:12

Fairly trivial merge conflict. Let's wait for the patchbot just to be safe.

---

New commits:

b483c8e

Merge branch 'develop' into t/23211/mark_morphisms_as_coercions

[saraedum]

Work Issues: waiting for the patchbot → positive review

[roed314]

comment:14

I just ran tests: they all pass.

[roed314]

Changed work issues from waiting for the patchbot → positive review to none

[vbraun]

comment:15

sage -t --long --warn-long 73.0 src/doc/en/thematic_tutorials/coercion_and_categories.rst
**********************************************************************
File "src/doc/en/thematic_tutorials/coercion_and_categories.rst", line 826, in doc.en.thematic_tutorials.coercion_and_categories
Failed example:
    P1.coerce_map_from(P2)
Expected:
    Conversion map:
      From: Multivariate Polynomial Ring in w, v over Integer Ring
      To:   Multivariate Polynomial Ring in v, w over Rational Field
Got:
    Coercion map:
      From: Multivariate Polynomial Ring in w, v over Integer Ring
      To:   Multivariate Polynomial Ring in v, w over Rational Field
**********************************************************************
1 item had failures:
   1 of 192 in doc.en.thematic_tutorials.coercion_and_categories
    [191 tests, 1 failure, 0.72 s]
----------------------------------------------------------------------
sage -t --long --warn-long 73.0 src/doc/en/thematic_tutorials/coercion_and_categories.rst  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 2.1 seconds
    cpu time: 0.7 seconds
    cumulative wall time: 0.7 seconds

and

sage -t --long --warn-long 73.0 src/doc/en/reference/coercion/index.rst  # 1 doctest failed
Running doctests with ID 2017-06-17-14-11-34-0b4119bb.
Git branch: develop
Using --optional=mpir,python2,sage
Doctesting 1 file.
sage -t --long --warn-long 73.0 src/doc/en/reference/coercion/index.rst
**********************************************************************
File "src/doc/en/reference/coercion/index.rst", line 223, in doc.en.reference.coercion.index
Failed example:
    cm.explain(ZZ['x','y'], QQ['x'])
Expected:
    Coercion on left operand via
       Conversion map:
         From: Multivariate Polynomial Ring in x, y over Integer Ring
         To:   Multivariate Polynomial Ring in x, y over Rational Field
    Coercion on right operand via
       Conversion map:
         From: Univariate Polynomial Ring in x over Rational Field
         To:   Multivariate Polynomial Ring in x, y over Rational Field
    Arithmetic performed after coercions.
    Result lives in Multivariate Polynomial Ring in x, y over Rational Field
    Multivariate Polynomial Ring in x, y over Rational Field
Got:
    Coercion on left operand via
        Coercion map:
          From: Multivariate Polynomial Ring in x, y over Integer Ring
          To:   Multivariate Polynomial Ring in x, y over Rational Field
    Coercion on right operand via
        Coercion map:
          From: Univariate Polynomial Ring in x over Rational Field
          To:   Multivariate Polynomial Ring in x, y over Rational Field
    Arithmetic performed after coercions.
    Result lives in Multivariate Polynomial Ring in x, y over Rational Field
    Multivariate Polynomial Ring in x, y over Rational Field
**********************************************************************

[sagetrac-git]

Changed commit from b483c8e to 78807fa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

78807fa

fix doctest errors

[vbraun]

Changed branch from u/saraedum/mark_morphisms_as_coercions to 78807fa

[fchapoton]

comment:19

you introduced a bad trac role, please review #23526

[fchapoton]

Changed commit from 78807fa to none

[roed314]

comment:20

Replying to @fchapoton:

you introduced a bad trac role, please review #23526

Oops! Sorry about that.