Coercions between Function Fields

[saraedum]

The following are desired features.

Coercions between base fields should induce coercions on function fields:

sage: K.<x> = FunctionField(QQ)
sage: L.<x> = FunctionField(GaussianIntegers().fraction_field())
sage: L.has_coerce_map_from(K)
True

Also in towers:

sage: K.<x> = FunctionField(QQ)
sage: R.<y> = K[]
sage: L.<y> = K.extension(y^3 + 1)
sage: K.<x> = FunctionField(GaussianIntegers().fraction_field())
sage: R.<y> = K[]
sage: M.<y> = K.extension(y^3 + 1)
sage: M.has_coerce_map_from(L)
True

And when the base ring coerces into the extension:

sage: K.<x> = FunctionField(QQ)
sage: R.<I> = K[]
sage: L.<I> = K.extension(I^2 + 1)
sage: M.<x> = FunctionField(GaussianIntegers().fraction_field())
sage: M.has_coerce_map_from(L) # not tested, base_morphism is not implemented
True

Component: commutative algebra

Keywords: sd86.5

Author: David Roe

Branch/Commit: e2ad9b3

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/23167

[roed314]

Branch: u/roed/coercions_between_function_fields

[roed314]

Commit: c227ee7

[roed314]

New commits:

c227ee7

Adding more coercions between function fields and the ability to specify a morphism on the base field or constant field

[saraedum]

Author: David Roe

[saraedum]

Changed branch from u/roed/coercions_between_function_fields to u/saraedum/coercions_between_function_fields

[saraedum]

Changed commit from c227ee7 to 369a518

[saraedum]

comment:5

Positive review. But one doctest fails because an is_injective is not implemented. I think that we should just disable the doctest because the failing doctest is not in the scope of this. (We discussed several ways of fixing this. The best would probably be to change the DefaultConvertMap to be a DefaultCoerceMap [does not exist yet] which is in the category of domain and codomain and would therefore by magically be injective.)

---

New commits:

369a518

Remove obsolete not implemented comments

[saraedum]

Reviewer: Julian Rüth

[saraedum]

Work Issues: one doctest fails

[roed314]

Changed branch from u/saraedum/coercions_between_function_fields to u/roed/coercions_between_function_fields

[roed314]

comment:9

I disabled the doctest. See #23184 for a followup which should allow the doctest to be re-enabled.

---

New commits:

b333178

Disable doctest for not-yet-working coercion

[roed314]

Changed commit from 369a518 to b333178

[vbraun]

comment:11

Documentation doesn't build

[vbraun]

comment:12

Was #23152...

[vbraun]

comment:13

sage -t --long --warn-long 69.1 src/sage/categories/rings.py
**********************************************************************
File "src/sage/categories/rings.py", line 97, in sage.categories.rings.Rings.MorphismMethods.is_injective
Failed example:
    f = K.hom([codomain(1)]); f
Exception raised:
    Traceback (most recent call last):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 509, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 872, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.categories.rings.Rings.MorphismMethods.is_injective[8]>", line 1, in <module>
        f = K.hom([codomain(Integer(1))]); f
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/rings/function_field/function_field.py", line 1935, in hom
        raise ValueError("You must specify a morphism on the base field")
    ValueError: You must specify a morphism on the base field
**********************************************************************
File "src/sage/categories/rings.py", line 102, in sage.categories.rings.Rings.MorphismMethods.is_injective
Failed example:
    f.is_injective()
Expected:
    False
Got:
    True
**********************************************************************

[saraedum]

Changed branch from u/roed/coercions_between_function_fields to u/saraedum/coercions_between_function_fields

[sagetrac-git]

Changed commit from b333178 to e2ad9b3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e2ad9b3

Fix zero morphism check

[saraedum]

comment:16

tests pass; david agreed to this fix.

[saraedum]

Changed work issues from one doctest fails to none

[vbraun]

Changed branch from u/saraedum/coercions_between_function_fields to e2ad9b3