-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category of number field morphisms is always Rings #22001
Comments
comment:2
Why would we ignore the cat keyword? Maybe category support was not that great at the time? Let's see what the patchbot thinks. |
Changed branch from u/saraedum/category_of_number_field_morphisms_is_always_rings to none |
comment:3
Btw. the comment that it is ignored was introduced in
so there is no further info on this. |
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:5
It looks like you deleted the branch when you set it to needs review. I'm putting the branch back, but if there's something wrong with the branch let me know. New commits:
|
Reviewer: David Roe |
comment:6
Looks good to me. |
comment:7
See patchbot: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Do you know why |
comment:11
It is mentioned here: https://github.com/sagemath/sage-prod/blob/master/src/sage/categories/category.py#L1299 |
comment:12
The failing doctest is some latex issue of the patchbot. I don't think it is related to the changes here. |
comment:13
Looks good, and patchbot says all tests pass. |
Changed branch from u/saraedum/category_of_number_field_morphisms_is_always_rings to |
comment:15
See #23910 for relative number field homsets. |
Changed commit from |
In the following example, the category should be
NumberFields()
CC: @roed314 @xcaruso
Component: number fields
Author: Julian Rüth
Branch:
07936de
Reviewer: David Roe
Issue created by migration from https://trac.sagemath.org/ticket/22001
The text was updated successfully, but these errors were encountered: