Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category of number field morphisms is always Rings #22001

Closed
saraedum opened this issue Nov 30, 2016 · 21 comments
Closed

Category of number field morphisms is always Rings #22001

saraedum opened this issue Nov 30, 2016 · 21 comments

Comments

@saraedum
Copy link
Member

In the following example, the category should be NumberFields()

sage: R.<x> = QQ[]
sage: K.<a> = QQ.extension(x^2 + 1)
sage: K.hom([a]).category_for()
Category of rings

CC: @roed314 @xcaruso

Component: number fields

Author: Julian Rüth

Branch: 07936de

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/22001

@saraedum saraedum added this to the sage-7.5 milestone Nov 30, 2016
@saraedum
Copy link
Member Author

@saraedum
Copy link
Member Author

comment:2

Why would we ignore the cat keyword? Maybe category support was not that great at the time? Let's see what the patchbot thinks.

@saraedum
Copy link
Member Author

Changed branch from u/saraedum/category_of_number_field_morphisms_is_always_rings to none

@saraedum
Copy link
Member Author

comment:3

Btw. the comment that it is ignored was introduced in

commit 2cda3cde81efa0b5546e60170bee7ae084263a4f
Author: William Stein <[email protected]>
Date:   Sun Sep 16 23:02:21 2007 -0700

    work in progress on algebraic number theory.

so there is no further info on this.

@saraedum

This comment has been minimized.

@roed314
Copy link
Contributor

roed314 commented Nov 30, 2016

Commit: 2d2818f

@roed314
Copy link
Contributor

roed314 commented Nov 30, 2016

comment:5

It looks like you deleted the branch when you set it to needs review. I'm putting the branch back, but if there's something wrong with the branch let me know.


New commits:

2d2818fDo not ignore the cat keyword of number field morphisms

@roed314
Copy link
Contributor

roed314 commented Nov 30, 2016

@roed314
Copy link
Contributor

roed314 commented Nov 30, 2016

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented Nov 30, 2016

comment:6

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Dec 2, 2016

comment:7

See patchbot:
sage -t --long --warn-long 53.9 src/sage/schemes/projective/projective_morphism.py # 2 doctests failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2016

Changed commit from 2d2818f to 07936de

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

07936deA morphism of a number field is a morphism of a ring and vice versa

@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2016

New commits:

07936deA morphism of a number field is a morphism of a ring and vice versa

New commits:

07936deA morphism of a number field is a morphism of a ring and vice versa

@roed314
Copy link
Contributor

roed314 commented Dec 7, 2016

comment:10

Do you know why self.homset_category().is_full_subcategory(x.category_for()) returns False?

@saraedum
Copy link
Member Author

saraedum commented Dec 7, 2016

@saraedum
Copy link
Member Author

saraedum commented Dec 9, 2016

comment:12

The failing doctest is some latex issue of the patchbot. I don't think it is related to the changes here.

@roed314
Copy link
Contributor

roed314 commented Dec 20, 2016

comment:13

Looks good, and patchbot says all tests pass.

@vbraun
Copy link
Member

vbraun commented Jan 23, 2017

@jdemeyer
Copy link
Contributor

comment:15

See #23910 for relative number field homsets.

@jdemeyer
Copy link
Contributor

Changed commit from 07936de to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants