-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enumeration of finitely generated semigroups #20403
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Deprecation ticket is #20404. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Frédéric Chapoton |
comment:7
looks good to me |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
|
Dependencies: #13580 |
comment:9
Trivial conflict/rebase over #13580. |
comment:11
See patchbot |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
There is another failure on 32-bit that seems to come from this ticket: http://build.sagedev.org/release/builders/%20%20slow%20AIMS%20%20%28Debian%207%2032%20bit%29%20incremental/builds/479/steps/shell_4/logs/stdio |
comment:15
My own doctesting earlier this afternoon, complained about a tab in |
comment:16
The tab character should be fixed in 6272efd. I am actually surprised the breadth first search is so consistent. It is somewhat non-deterministic because it uses a set for the next level, whereas it probably should be a list. However, that is an issue for another ticket because it will require much more large-scale changes. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:18
Quick-n-dirty fix for doctest order. |
Changed branch from public/semigroups/iterator_finitely_generated_semigroups-20403 to |
We use breadth-first-search via
RecursivelyEnumeratedSet
to iterate through the elements of a finitely generated semigroup. This will allow us to deprecateTransitiveIdeal*
Depends on #13580
CC: @sagetrac-sage-combinat @nthiery
Component: algebra
Author: Travis Scrimshaw
Branch/Commit:
702d333
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/20403
The text was updated successfully, but these errors were encountered: