Skip to content

upgrade to pynac-0.3.3 #18155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwst opened this issue Apr 10, 2015 · 35 comments
Closed

upgrade to pynac-0.3.3 #18155

rwst opened this issue Apr 10, 2015 · 35 comments

Comments

@rwst
Copy link
Contributor

rwst commented Apr 10, 2015

Don't use attached files use https://drive.google.com/folderview?id=0B4PmRyK1JXgHfmJmbWZ5NnVtMnNITTVHQ2hCci1WVnhLbC1PeC1YbzRQLUpidU9yY0x3Qjg&usp=sharing

* fixed the series expansion of zeta(s) around 1
* print_latex of wildcards
* clear the libtool versioning scheme
* sync with current GiNaC as much as possible

Upgrade will require a few doctests to adapt, see https://groups.google.com/d/topic/sage-devel/hwQXxFmutcU/discussion

Dependent tickets: #15047, #15846

Upstream: Reported upstream. Developers acknowledge bug.

Component: packages: standard

Author: Ralf Stephan

Branch: 839c49f

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/18155

@rwst rwst added this to the sage-6.6 milestone Apr 10, 2015
@rwst

This comment has been minimized.

@rwst rwst self-assigned this Apr 11, 2015
@rwst

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Branch: u/rws/upgrade_to_pynac_0_3_3

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

comment:4

Attachment: pynac-0.3.3.tar.bz2.gz

New commits:

77b3ca518155: upgrade to pynac-0.3.3

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Author: Ralf Stephan

@rwst

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Commit: 77b3ca5

@behackl
Copy link
Member

behackl commented Apr 11, 2015

comment:5
Starting build...
Running build_pynac...
configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."
make: *** No targets specified and no makefile found.  Stop.
Error building pynac.

real	0m0.073s
user	0m0.017s
sys	0m0.003s
************************************************************************
Error installing package pynac-0.3.3
************************************************************************

It seems that you linked, for example, install-sh -> /usr/share/automake-1.13/install-sh. I have automake-1.15 installed, thus install-sh cannot be found.

In Pynac 0.3.2, these files were actually included in the .tar.bz2, I think.

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

comment:7

Ah, the h option of tar is needed.

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Changed branch from u/rws/upgrade_to_pynac_0_3_3 to u/rws/18155-1

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Attachment: pynac-0.3.3.tar.2.bz2.gz

version without soft links

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

comment:9

Now the attachment has the wrong name so you need to rename in your upstream/.


New commits:

2db262118155: upgrade to pynac-0.3.3

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

Changed commit from 77b3ca5 to 2db2621

@behackl
Copy link
Member

behackl commented Apr 11, 2015

comment:10

Passes make ptestlong. Thanks for pushing a new version!

@behackl
Copy link
Member

behackl commented Apr 11, 2015

Reviewer: Benjamin Hackl

@rwst
Copy link
Contributor Author

rwst commented Apr 11, 2015

comment:11

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Apr 12, 2015

comment:12

Attaching larger files to trac isn't ideal, they are stored in the database forever. If you don't have a place to host files ask William for an account on boxen...

@vbraun
Copy link
Member

vbraun commented Apr 12, 2015

comment:13

The pynac-0.3.3.tar.bz2 file is apparently not the one you envisioned:

Attempting to download package pynac-0.3.3
>>> Trying to download http://www.sagemath.org/packages/upstream/pynac/pynac-0.3.3.tar.bz2
[............................................................]
Checksum: 76fea7a56a14d52eb2d14aaf11e21598bd68a8b4 vs 1afc858a8d18050604655b69096fcf13f42df73c

The file is now cached by all buildbots. Note that I can't possibly read all tickets that I'm merging. Can you change the tarball name.

@vbraun
Copy link
Member

vbraun commented Apr 13, 2015

comment:21

As I said before, pynac-0.3.3.tar.bz2 is now cached on the buildbots. You can either manually delete the cached copy on each build slave, or you rename the tarball (e.g. to pynac-0.3.3.tar.gz)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2015

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

839c49f18155: file change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2015

Changed commit from 216e29c to 839c49f

@vbraun
Copy link
Member

vbraun commented Apr 14, 2015

Changed branch from u/rws/18155-1 to 839c49f

@vbraun
Copy link
Member

vbraun commented Apr 15, 2015

Changed commit from 839c49f to none

@vbraun
Copy link
Member

vbraun commented Apr 15, 2015

comment:25

On OSX:

sage -t --long src/doc/en/prep/Calculus.rst
**********************************************************************
File "src/doc/en/prep/Calculus.rst", line 396, in doc.en.prep.Calculus
Failed example:
    integral(h,(x,0,pi/8))
Expected:
    1/2*log(sin(1/8*pi) + 1) - 1/2*log(-sin(1/8*pi) + 1)
Got:
    -1/2*log(-sin(1/8*pi) + 1) + 1/2*log(sin(1/8*pi) + 1)
**********************************************************************
1 item had failures:
   1 of  58 in doc.en.prep.Calculus
    [57 tests, 1 failure, 27.74 s]

@vbraun vbraun reopened this Apr 15, 2015
@behackl
Copy link
Member

behackl commented Apr 15, 2015

comment:26

This is strange. On Arch Linux, I have

sage -t --long --warn-long 81.6 src/doc/en/prep/Calculus.rst
    [57 tests, 11.79 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

and especially

sage: -1/2*log(-sin(1/8*pi) + 1) + 1/2*log(sin(1/8*pi) + 1)
1/2*log(sin(1/8*pi) + 1) - 1/2*log(-sin(1/8*pi) + 1)

Nothing changes in my results if I rebase this branch on top of sage-6.7.beta0.

Does anyone have an idea what could cause the change in the order of summands on OSX?

@rwst
Copy link
Contributor Author

rwst commented Apr 15, 2015

comment:28

See also pynac/pynac#18

@rwst
Copy link
Contributor Author

rwst commented Apr 15, 2015

Upstream: Reported upstream. Developers acknowledge bug.

@rwst rwst removed this from the sage-6.6 milestone Apr 15, 2015
@rwst rwst added the pending label Apr 15, 2015
@rwst
Copy link
Contributor Author

rwst commented Apr 17, 2015

comment:30

This is now abandoned in favor of #18237. Please review that ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants