Skip to content

Deprecation error in poset join_matrix #17356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jm58660 mannequin opened this issue Nov 17, 2014 · 8 comments
Closed

Deprecation error in poset join_matrix #17356

jm58660 mannequin opened this issue Nov 17, 2014 · 8 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-6.5

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Nov 17, 2014

meet_matrix() and join_matrix() were moved from posets to lattices. I forgot to add from sage.misc.superseded import deprecation to functions in posets.py. Sorry!

CC: @nathanncohen

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: da41387

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/17356
@jm58660 jm58660 mannequin added this to the sage-6.5 milestone Nov 17, 2014
@jm58660 jm58660 mannequin added c: combinatorics labels Nov 17, 2014
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 17, 2014

Branch: u/jmantysalo/deprecation_error_in_poset_join_matrix

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 17, 2014

Author: Jori Mäntysalo

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 17, 2014

New commits:

da41387Added import statement.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Nov 17, 2014

Commit: da41387

@jm58660 jm58660 mannequin added the s: needs review label Nov 17, 2014
@fchapoton
Copy link
Contributor

comment:3

This would also be done by #17354, if you review it..

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 17, 2014

comment:4

Oops. Right :-/

Turns out the function was only called on lattices, which is a rather good sign.

I don't think it is worth adding a doctest as the function will be removed asap.

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 17, 2014

Reviewer: Nathann Cohen

@vbraun
Copy link
Member

vbraun commented Nov 19, 2014

Changed branch from u/jmantysalo/deprecation_error_in_poset_join_matrix to da41387

@vbraun vbraun closed this as completed in 7f124cb Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
2 participants
@vbraun @fchapoton