Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow complex functions in implicit_plot #16899

Closed
sagetrac-ajdunlap mannequin opened this issue Aug 28, 2014 · 10 comments
Closed

Allow complex functions in implicit_plot #16899

sagetrac-ajdunlap mannequin opened this issue Aug 28, 2014 · 10 comments

Comments

@sagetrac-ajdunlap
Copy link
Mannequin

sagetrac-ajdunlap mannequin commented Aug 28, 2014

Currently implicit_plot does not allow you to plot the zero sets of complex functions. It would be nice if one could do this. (This was mentioned in an email thread last year but I haven't found any other work on it.)

Depends on #32234
Depends on #8450

CC: @orlitzky

Component: graphics

Keywords: fast_callable

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/16899

@sagetrac-ajdunlap sagetrac-ajdunlap mannequin added this to the sage-6.4 milestone Aug 28, 2014
@sagetrac-ajdunlap
Copy link
Mannequin Author

sagetrac-ajdunlap mannequin commented Aug 28, 2014

comment:1

I think this would be solved by switching contour_plot to use fast_callable instead of fast_float, as was done for plot in #15030.

@sagetrac-ajdunlap
Copy link
Mannequin Author

sagetrac-ajdunlap mannequin commented Aug 28, 2014

Changed keywords from none to fast_callable

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 22, 2021

Dependencies: #32234

@mkoeppe mkoeppe modified the milestones: sage-6.4, sage-9.4 Jul 22, 2021
@orlitzky
Copy link
Contributor

comment:4

This is probably fixed by #8450, but bugs in contour_plot are getting in the way (#21042).

@orlitzky
Copy link
Contributor

comment:5

The following modification of the email example z - |z| works after #8450:

sage: x,y = SR.var('x,y')                                                       
sage: z = x + I*y                                                               
sage: f = (z - abs(z)).real()                                                   
sage: implicit_plot(f + 0.2, (0,1), (0,1))

First, you have to take the real part of the answer, since the plotting functions are expecting a real result. But then to avoid the issue in #21042, we have to perturb the whole thing (by 0.2, in my example).

If we are willing to accept the need to add real() onto the example, then I think we can consider this fixed by #8450, and deal with the contour_plot() zero issue on its own ticket.

@orlitzky
Copy link
Contributor

Changed dependencies from #32234 to #32234, #8450

@orlitzky orlitzky removed this from the sage-9.4 milestone Jul 29, 2021
@dimpase
Copy link
Member

dimpase commented Dec 3, 2021

comment:6

Is an example akin to the one in comment:5 in docstrings of #8450 or #21042 ?

@orlitzky
Copy link
Contributor

orlitzky commented Dec 3, 2021

comment:7

#8450 adds a similar test for contour_plot, which is what implicit_plot uses, so I think we're good.

@dimpase
Copy link
Member

dimpase commented Dec 3, 2021

comment:8

OK.

@dimpase
Copy link
Member

dimpase commented Dec 3, 2021

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants