Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some cmp parameters by key paramters #16853

Closed
a-andre opened this issue Aug 19, 2014 · 8 comments
Closed

Replace some cmp parameters by key paramters #16853

a-andre opened this issue Aug 19, 2014 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-6.4

Comments

@a-andre
Copy link
Contributor

a-andre commented Aug 19, 2014

The cmp parameter has been removed from sorted() and List.sort() in python3.

This ticket is part of #16536.

Component: misc

Author: André Apitzsch

Branch: fb40e7c

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/16853
@a-andre a-andre added this to the sage-6.4 milestone Aug 19, 2014
@a-andre
Copy link
Contributor Author

a-andre commented Aug 19, 2014

Commit: fb40e7c

@a-andre
Copy link
Contributor Author

a-andre commented Aug 19, 2014

Branch: u/aapitzsch/ticket/16853

@a-andre
Copy link
Contributor Author

a-andre commented Aug 19, 2014

New commits:

fb40e7creplace some cmp parameters by key parameters

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

Looks good to me, and the buildbot is happy too.

@vbraun
Copy link
Member

vbraun commented Sep 8, 2014

Changed branch from u/aapitzsch/ticket/16853 to fb40e7c

@vbraun vbraun closed this as completed in e01367d Sep 8, 2014
@a-andre
Copy link
Contributor Author

a-andre commented Sep 8, 2014

comment:5

Frédéric, thanks for reviewing.

Could you also review #16442 and #16529, should be easy.

@a-andre
Copy link
Contributor Author

a-andre commented Sep 8, 2014

Changed commit from fb40e7c to none

@wluebbe wluebbe mannequin mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @a-andre