Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random failure in elliptic_curves/constructor.py #16744

Closed
vbraun opened this issue Jul 30, 2014 · 8 comments
Closed

Random failure in elliptic_curves/constructor.py #16744

vbraun opened this issue Jul 30, 2014 · 8 comments

Comments

@vbraun
Copy link
Member

vbraun commented Jul 30, 2014

The code is from #11474:

sage -t --long src/sage/schemes/elliptic_curves/constructor.py
**********************************************************************
File "src/sage/schemes/elliptic_curves/constructor.py", line 365, in sage.schemes.elliptic_curves.constructor.EllipticCurveFactory.create_key_and_extra_args
Failed example:
    E.gens()
Expected:
    [(-2 : 3 : 1), (1 : -1 : 1), (4 : -7 : 1)]
Got:
    [(-2 : 3 : 1), (-7/4 : 25/8 : 1), (1 : -1 : 1)]
**********************************************************************
File "src/sage/schemes/elliptic_curves/constructor.py", line 368, in sage.schemes.elliptic_curves.constructor.EllipticCurveFactory.create_key_and_extra_args
Failed example:
    E.gens()
Expected:
    [(-2 : 3 : 1), (1 : -1 : 1), (4 : -7 : 1)]
Got:
    [(-2 : 3 : 1), (-7/4 : 25/8 : 1), (1 : -1 : 1)]
**********************************************************************
1 item had failures:
   2 of  19 in sage.schemes.elliptic_curves.constructor.EllipticCurveFactory.create_key_and_extra_args
    [182 tests, 2 failures, 67.70 s]

CC: @pjbruin @JohnCremona

Component: elliptic curves

Keywords: random_fail

Author: Peter Bruin

Branch/Commit: b4b48fd

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/16744

@vbraun vbraun added this to the sage-6.3 milestone Jul 30, 2014
@JohnCremona
Copy link
Member

comment:1

It seems that this doctest is intended to illustrate that specifying "gens=" when cponstructing a curve from its label might be ignored when the curve is in the database. But there is a danger: the default database contains curves of conductors up to 10000 but does not contain their generators. So this is a test whose output will depend on whether or not the optional extended database is installed, something which we have been trying to avoid.

I hope the authors of #11474 (not me!) will be able to say whether I have got this diagnosis right.

@pjbruin
Copy link
Contributor

pjbruin commented Jul 30, 2014

comment:2

I'm responsible for that doctest. The unexpected [(-2 : 3 : 1), (-7/4 : 25/8 : 1), (1 : -1 : 1)] are the generators found by mwrank, not the ones in the database. The fact that the same curve is used in an earlier doctest in that file might be the cause; I'll look into it.

@pjbruin
Copy link
Contributor

pjbruin commented Jul 30, 2014

Author: Peter Bruin

@pjbruin
Copy link
Contributor

pjbruin commented Jul 30, 2014

comment:3

The problem was that curve 5077a1 could still be in the cache from an earlier doctest. In this case the gens parameter (in the first failing doctest) would be ignored and the generators would be computed using mwrank. This commit replaces the curve 5077a1 by 433a1, which is not used in any other doctest.

@pjbruin
Copy link
Contributor

pjbruin commented Jul 30, 2014

Commit: b4b48fd

@pjbruin
Copy link
Contributor

pjbruin commented Jul 30, 2014

@jdemeyer
Copy link
Contributor

jdemeyer commented Aug 5, 2014

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member Author

vbraun commented Aug 6, 2014

Changed branch from u/pbruin/16744-EllipticCurve_gens_random_failure to b4b48fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants